After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785922 - "Toronto, Canada" mistakenly called "Tortola, Kanada" in the German localisation
"Toronto, Canada" mistakenly called "Tortola, Kanada" in the German localisation
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Date and Time
git master
Other Linux
: Normal normal
: ---
Assigned To: Kalev Lember
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-07 05:12 UTC by Richard Schwarting
Modified: 2017-08-07 19:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GNOME Control Centre screen showing Tortola, Kanada instead of Toronto, Canada (25.83 KB, image/png)
2017-08-07 05:12 UTC, Richard Schwarting
  Details
Map picker showing Tortola, Kanada instead of Toronto, Kanada (16.00 KB, image/png)
2017-08-07 05:13 UTC, Richard Schwarting
  Details
Patch fixing Toronto as Tortola for 7 locales (3.50 KB, patch)
2017-08-07 05:25 UTC, Richard Schwarting
none Details | Review
Patch fixing Toronto as Tortola for 7 locales, now with formatted commit message (3.73 KB, patch)
2017-08-07 19:41 UTC, Richard Schwarting
committed Details | Review

Description Richard Schwarting 2017-08-07 05:12:55 UTC
Created attachment 357082 [details]
GNOME Control Centre screen showing Tortola, Kanada instead of Toronto, Canada

When I go to set my time zone, clicking on the region where Toronto, Canada is, it tells me the reference city is "Tortola". 

Affected file:
/usr/share/locale/de/LC_MESSAGES/gnome-control-center-2.0-timezones.mo

English section:
America/Thunder_Bay
America/Tijuana
America/Toronto
America/Tortola
America/Vancouver
America/Virgin

German section:
Amerika/Thunder_Bay
Amerika/Tijuana
Amerika/Tortola
Amerika/Tortola
Amerika/Vancouver
Amerika/Virgin

Note the third instance of each.
Comment 1 Richard Schwarting 2017-08-07 05:13:33 UTC
Created attachment 357083 [details]
Map picker showing Tortola, Kanada instead of Toronto, Kanada
Comment 2 Richard Schwarting 2017-08-07 05:25:04 UTC
Created attachment 357084 [details] [review]
Patch fixing Toronto as Tortola for 7 locales

Used grep and found 6 more locales that encoded Toronto as Tortola.

Made sure not to change actual Tortola to Toronto.
Comment 3 Piotr Drąg 2017-08-07 14:42:06 UTC
Review of attachment 357084 [details] [review]:

Looks great!

Please reword the commit message according to https://wiki.gnome.org/Git/CommitMessages so we can push it.
Comment 4 Richard Schwarting 2017-08-07 19:41:03 UTC
Created attachment 357140 [details] [review]
Patch fixing Toronto as Tortola for 7 locales, now with formatted commit message

Tried reformatting according to https://wiki.gnome.org/Git/CommitMessages. :)
Comment 5 Piotr Drąg 2017-08-07 19:50:03 UTC
Comment on attachment 357140 [details] [review]
Patch fixing Toronto as Tortola for 7 locales, now with formatted commit message

Almost perfect. I edited it slightly and pushed:

https://git.gnome.org/browse/gnome-control-center/commit/?id=1a310bb11dcbe584e43318f35a62654bcb96013b

Thank you!