GNOME Bugzilla – Bug 785879
Behaviour when fullscreen and resizing could be improved
Last modified: 2017-08-11 09:17:26 UTC
Created attachment 357052 [details] [review] Patch for the first issue Love gnome characters, just it always bugged me how it behaves poorly on large screens. The issue is: 1. Open Gnome Characters 2. Maximize the window (on large screen, like 1080p) 3. Click to view a long category ("Pictures") 4. Notice that screen is basically empty, and you can not scroll to load more The issue also happens when resizing: 1. Open Gnome Characters, leave it at the default size 3. Click to view a long category ("Pictures"). Do not scroll 2. Maximize the window (on large screen, like 1080p) 4. Notice that screen is (still) basically empty, and you can not scroll to load more Please see the 2 patches provided.
Created attachment 357053 [details] [review] Patch for the 2nd issue
Review of attachment 357052 [details] [review]: Thank you, good point. The patch looks fine, except a nit: ::: src/characterList.js @@ +507,3 @@ + // Use our parents allocation; we aren't visible before we do the + // initial search, so our allocation is 1x1 + const allocation = this.get_parent().get_allocation(); "let" seems more appropriate here (and the 3 occurrences below) than "const", because the values are not constant.
Review of attachment 357053 [details] [review]: Looks good to me.
Thanks, I've attached a version of the first patch that uses "let" instead of "const". Note that "const" is not just for constants. The AirBnB style guide for example [1] says that it should be used as the default. It just stops you from reassigning to the variable; making the flow of the program much clearer. [1] https://github.com/airbnb/javascript#references
Created attachment 357157 [details] [review] Patch for the first issue; but with "let" instead of "const"
Thank you, pushed the patches.