After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785809 - libtracker-data: Drop redundant error path
libtracker-data: Drop redundant error path
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-08-04 12:12 UTC by Philip Withnall
Modified: 2017-08-04 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libtracker-data: Drop redundant error path (1.32 KB, patch)
2017-08-04 12:12 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2017-08-04 12:12:15 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2017-08-04 12:12:20 UTC 
Created attachment 356944 [details] [review]
libtracker-data: Drop redundant error path

prepare_for_exec() defines iface as non-nullable, so Vala automatically
(and correctly) inserts a g_return_val_if_fail (iface != NULL) for us.
That makes this error path redundant and unreachable.

Spotted by Coverity (CID #1452447).

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Carlos Garnacho 2017-08-04 13:02:00 UTC 
Comment on attachment 356944 [details] [review]
libtracker-data: Drop redundant error path

Makes sense indeed.
Comment 3 Philip Withnall 2017-08-04 13:28:52 UTC 
Attachment 356944 [details] pushed as bca8505 - libtracker-data: Drop redundant error path