After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785783 - Fix omission from the GtkVBox to GtkBox conversion
Fix omission from the GtkVBox to GtkBox conversion
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-03 15:55 UTC by astian
Modified: 2017-08-05 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix omission from the GtkVBox to GtkBox conversion (7.58 KB, patch)
2017-08-03 15:56 UTC, astian
committed Details | Review

Description astian 2017-08-03 15:55:04 UTC
Commits 7d6a5f17c and bd9f1a6ad (2013-06-09) that changed the users of
GtkVbox to GtkBox neglected to change the type names in the instance and
class structures (it changed only the GObject type IDs).

Maybe this wasn't noticed before because GtkVBox is in fact derived from
GtkBox, which means that when the GObject machinery accessed the
structure it simply used the smaller prefix memory area corresponding to
a GtkBox.  So this bug may have been inconsequential, but it does
illustrate the amount of trust (read "burden") that GObject places on
the programmer by casting types all over the place (not that it can do
much better while staying in C).
Comment 1 astian 2017-08-03 15:56:29 UTC
Created attachment 356873 [details] [review]
Fix omission from the GtkVBox to GtkBox conversion
Comment 2 Carlos Garcia Campos 2017-08-05 06:56:46 UTC
Comment on attachment 356873 [details] [review]
Fix omission from the GtkVBox to GtkBox conversion

Good catch! pushed.