After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785761 - "find" icon is deprecated
"find" icon is deprecated
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: ux
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-03 08:02 UTC by Laurent Bigonville
Modified: 2017-08-06 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove deprecated icon (915 bytes, patch)
2017-08-03 08:13 UTC, Jens Georg 		none Details | Review
Remove deprecated "find" icon (1.55 KB, patch)
2017-08-06 13:30 UTC, Jens Georg 		committed Details | Review

Description Laurent Bigonville 2017-08-03 08:02:17 UTC 
Hi,

It seems that shotwell is using the "find" (GTK_STOCK_FIND) icon which is deprecated (and even gone in recent GNOME version)

The replacement for this icon seems to be "edit-find" according to the documentation.

The new icon should be used instead
Comment 1 Jens Georg 2017-08-03 08:13:34 UTC 
Created attachment 356823 [details] [review]
remove deprecated icon

Thanks. That's the only place left I could find on master
Comment 2 Laurent Bigonville 2017-08-03 08:25:58 UTC 
I see an other occurrence in

src/searches/SearchesBranch.vala:    private static string single_search_icon = "find";
Comment 3 Jens Georg 2017-08-03 08:31:55 UTC 
Oh. Nasty. Thanks.
Comment 4 Jens Georg 2017-08-06 13:30:09 UTC 
Created attachment 357060 [details] [review]
Remove deprecated "find" icon
Comment 5 Jens Georg 2017-08-06 13:31:04 UTC 
Attachment 357060 [details] pushed as ad42f64 - Remove deprecated "find" icon