After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785756 - [PATCH] build-pipeline: add underscore to filename in error format regex
[PATCH] build-pipeline: add underscore to filename in error format regex
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-03 06:04 UTC by Xiang Fan
Modified: 2017-08-03 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (3.10 KB, patch)
2017-08-03 06:04 UTC, Xiang Fan
accepted-commit_now Details | Review

Description Xiang Fan 2017-08-03 06:04:09 UTC
Created attachment 356816 [details] [review]
Patch

This patch allows the regex to match source files with underscore. Otherwise
source files such as "a_b.c" would be recognized as "b.c" in the build
panel.
Comment 1 sébastien lafargue 2017-08-03 17:58:19 UTC
Review of attachment 356816 [details] [review]:

LGTM
Comment 2 sébastien lafargue 2017-08-03 18:02:19 UTC
thanks, commited as 793e284