After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785719 - [itip] Get Organizer's Sent-By name from Sender header
[itip] Get Organizer's Sent-By name from Sender header
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.24.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2017-08-02 08:23 UTC by Robert Munteanu
Modified: 2018-09-27 11:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Robert Munteanu 2017-08-02 08:23:05 UTC
Evo 3.24.3, EWS account.

I sometimes get invites which contain both a 'From' and a 'Sender' header. Both of these contain both a name and an email, e.g.

From: Foo <foo@example.com>
Sender: Bar <bar@example.com>

Evolution displays these as

  Foo through bar@example.com requests your presence ...

I would expect the text to be 

  Foo through Bar requests your presence ...
Comment 1 Milan Crha 2017-08-03 12:25:15 UTC
Thanks for a bug report. This is not taken from the message headers, it's taken from the received component instead. It's a sentby parameter on an ORGANIZER property of the component. It's better to rely on the component, than on the message headers, because the component can be resent, while the other details of the event are still the same.

You can view the component in the message source (Ctrl+U), maybe encoded in base64. I do not have any such component here, unfortunately, thus I do not know what exactly is written there.
Comment 2 Robert Munteanu 2017-08-03 13:09:27 UTC
I see.

I think I have it - it's a part in the message, something like:

Content-Type: text/calendar
Content-Transfer-Encoding: 8bit

BEGIN:VCALENDAR
(snip)
ORGANIZER;CN=Foo;SENT-BY="MAILTO:bar@example.com":MAILTO: foo@example.com

So indeed the name is not present in the component. Would it be possible to fall back to the message headers or the contact database if the name is not available in the component? I guess this is what other mail clients do.
Comment 3 Milan Crha 2017-08-03 14:02:29 UTC
The message is there, thus some lookup could be made, though I'm wondering whether it really worth it. I know that it would be nicer to have there the name (and eventually also the address), when the SENT-BY parameter matches the Sender header in the message, but does it provide any special feature or anything? I'm not against it, I'm only wondering.
Comment 4 Robert Munteanu 2017-08-03 14:03:54 UTC
No, it does not provide anything meaningful, for me it's just a nice-to-have polish item.
Comment 5 Milan Crha 2017-08-03 14:07:38 UTC
I see, thanks. This can be a nice simple thing to work on for a newcomer, thus I marked this as such. Once some will pick it it'll be eventually done. Having an example mbox file for testing would be very helpful, but I understand that it contains plenty of private information.
Comment 6 Robert Munteanu 2017-08-03 14:12:39 UTC
I can't (for now) provide a 'safe' invite as an example.
Comment 7 Milan Crha 2018-09-27 11:00:24 UTC
I decided to use both name and the email address in the Sent-By value, because the Sender header is usually not visible between the headers.

Created commit ed8f925449 in evo master (3.31.1+)