After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785717 - Add plain minus key to collapse thread
Add plain minus key to collapse thread
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2017-08-02 07:15 UTC by Paul Menzel
Modified: 2017-08-04 08:36 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Paul Menzel 2017-08-02 07:15:40 UTC
(This might be a GTK+ issue.)

In Evolution it should be possible to collapse a thread with the minus sign `-` and expand it with the plus sign `+`. There are several key codes for these signs, and with certain keyboard layouts it’s possible to enter different ones.

The key symbol *minus* does *not* collapse a thread.

```
KeyRelease event, serial 35, synthetic NO, window 0x1200001,
    root 0x4a1, subw 0x0, time 3960177, (373,572), root:(374,613),
    state 0x2000, keycode 66 (keysym 0xfe0c, ISO_First_Group), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: Falset returns: False

KeyPress event, serial 35, synthetic NO, window 0x1200001,
    root 0x4a1, subw 0x0, time 3957810, (373,572), root:(374,613),
    state 0x2000, keycode 46 (keysym 0x2d, minus), same_screen YES,
    XKeysymToKeycode returns keycode: 20
    XLookupString gives 1 bytes: (2d) "-"
    XmbLookupString gives 1 bytes: (2d) "-"
    XFilterEvent returns: False

KeyRelease event, serial 35, synthetic NO, window 0x1200001,
    root 0x4a1, subw 0x0, time 3957865, (373,572), root:(374,613),
    state 0x2000, keycode 46 (keysym 0x2d, minus), same_screen YES,
    XKeysymToKeycode returns keycode: 20
    XLookupString gives 1 bytes: (2d) "-"
    XFilterEvent returns: False

KeyRelease event, serial 35, synthetic NO, window 0x1200001,
    root 0x4a1, subw 0x0, time 3958088, (373,572), root:(374,613),
    state 0x2000, keycode 66 (keysym 0xfe0c, ISO_First_Group), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False
```

The key symbol *plus* does expand a thread though.

```
KeyPress event, serial 35, synthetic NO, window 0x1200001,
    root 0x4a1, subw 0x0, time 3959951, (373,572), root:(374,613),
    state 0x0, keycode 66 (keysym 0xff7e, Mode_switch), same_screen YES,
    XKeysymToKeycode returns keycode: 51
    XLookupString gives 0 bytes: 
    XmbLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyPress event, serial 35, synthetic NO, window 0x1200001,
    root 0x4a1, subw 0x0, time 3960058, (373,572), root:(374,613),
    state 0x2000, keycode 57 (keysym 0x2b, plus), same_screen YES,
    XLookupString gives 1 bytes: (2b) "+"
    XmbLookupString gives 1 bytes: (2b) "+"
    XFilterEvent returns: False

KeyRelease event, serial 35, synthetic NO, window 0x1200001,
    root 0x4a1, subw 0x0, time 3960122, (373,572), root:(374,613),
    state 0x2000, keycode 57 (keysym 0x2b, plus), same_screen YES,
    XLookupString gives 1 bytes: (2b) "+"
    XFilterEvent returns: False

KeyRelease event, serial 35, synthetic NO, window 0x1200001,
    root 0x4a1, subw 0x0, time 3960177, (373,572), root:(374,613),
    state 0x2000, keycode 66 (keysym 0xfe0c, ISO_First_Group), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False
```
Comment 1 Milan Crha 2017-08-03 12:00:02 UTC
Thanks for a bug report. You can use Shift+minus, which [can be/]is underscore, but I see it's a valid request, gtk+ tree view does that too, thus I added the plain minus to the list of keys to collapse thread.

Created commit 2c4487e in evo master (3.25.90+)
Created commit d78edfe in evo gnome-3-24 (3.24.5+)
Comment 2 Paul Menzel 2017-08-04 07:24:56 UTC
(In reply to Milan Crha from comment #1)
> Thanks for a bug report. You can use Shift+minus, which [can be/]is
> underscore,

Not all people use the US layout, or standard QWERTY based layouts. (Everybody should use layouts which are better optimized anyway, like for German speaking people the Neo layout [1]. ;-))

> but I see it's a valid request, gtk+ tree view does that too,
> thus I added the plain minus to the list of keys to collapse thread.

Thank you for the quick solution!

> Created commit 2c4487e in evo master (3.25.90+)
> Created commit d78edfe in evo gnome-3-24 (3.24.5+)


[1] https://www.neo-layout.org/
Comment 3 Milan Crha 2017-08-04 08:36:37 UTC
(In reply to Paul Menzel from comment #2)
> Not all people use the US layout, or standard QWERTY based layouts.

Right, right, though this didn't work even with the US layout :)