GNOME Bugzilla – Bug 785663
kmssink: need check scaleable when start
Last modified: 2018-11-03 14:11:40 UTC
I create a new thread for this issue. Please refer to this link for detail info:https://bugzilla.gnome.org/show_bug.cgi?id=784599 There is a bug when driver not support scale. when video size is same as display resolution, show frame will not do retry because the setplane will never fail. But the scale result is not correct. We can do this check by set a fake plane. This bug will impact the videooverlay interface, because the implementation is based on driver scaleable capability.
Created attachment 357423 [details] [review] kmssink: add atomic check for scale capability Use atomic check can get the scale capability of driver, will keep retry setplane to be compatible with the driver not support atomic check
Hi all, Any Update?
Hi, From my side, I have been very busy lately, and my knowledge on the atomic API is none, so I would need to study it. Thus, from my side, I need more time to assess this patch.
I ask Daniel S. about mixing APIs, he didn't think it's a great idea. Feature sets between atomic/non-atomic could vary due to porting still being in progress on some drivers.
(In reply to Nicolas Dufresne (stormer) from comment #4) > I ask Daniel S. about mixing APIs, he didn't think it's a great idea. > Feature sets between atomic/non-atomic could vary due to porting still being > in progress on some drivers. Not feature setting just testing and check.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/591.