Created attachment 356658 [details] [review]
build: Fix build when no Kerberos libraries are available

If gnome-online-accounts is configured --enable-kerberos=auto (or
unspecified), but no Kerberos libraries are available,
enable_kerberos=auto and have_kerberos=no, but the configure code
defines GOA_KERBEROS_ENABLED=1 anyway.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Created attachment 356659 [details] [review]
goa/client: Drop spurious trailing semicolon

This was causing a compiler warning.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Review of attachment 356658 [details] [review]:

Looks good. Thanks for catching this fallout from commit f8f1e79887d26530

I tried a few permutations of the --enable-kerberos flag (=yes,auto,no) with the dependencies available, and it didn't break distcheck. I assume you already checked without the dependencies.

Pushed after removing the "Signed-off-by:" since we don't use them in GNOME.

Review of attachment 356659 [details] [review]:

Interesting. Which compiler is this? I have gcc-6.3.1 on my laptop and the Fedora 27 builds are done using gcc-7.1.1 and I can't spot any warnings. For example: https://kojipkgs.fedoraproject.org//packages/gnome-online-accounts/3.25.4/2.fc27/data/logs/x86_64/build.log and https://kojipkgs.fedoraproject.org//packages/gnome-photos/3.25.1/1.fc27/data/logs/x86_64/build.log.

The reason I started using the semi-colon is to convince emacs' auto-indenter to treat that macro invocation like any other statement. Otherwise, it auto-indents the next line with 2 spaces. Also, don't we have a lot of instances of G_DEFINE_* invocations having trailing semi-colons? I am not that attached to the semi-colon. I just want to understand what's happening here.

(In reply to Debarshi Ray from comment #4)
> Review of attachment 356659 [details] [review] [review]:
> 
> Interesting. Which compiler is this? I have gcc-6.3.1 on my laptop and the
> Fedora 27 builds are done using gcc-7.1.1 and I can't spot any warnings. For
> example:
> https://kojipkgs.fedoraproject.org//packages/gnome-online-accounts/3.25.4/2.
> fc27/data/logs/x86_64/build.log and
> https://kojipkgs.fedoraproject.org//packages/gnome-photos/3.25.1/1.fc27/data/
> logs/x86_64/build.log.
> 
> The reason I started using the semi-colon is to convince emacs'
> auto-indenter to treat that macro invocation like any other statement.
> Otherwise, it auto-indents the next line with 2 spaces. Also, don't we have
> a lot of instances of G_DEFINE_* invocations having trailing semi-colons? I
> am not that attached to the semi-colon. I just want to understand what's
> happening here.

cc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)

It’s happening inside the g-ir-scanner execution.

The relevant bit of my compilation output is:

CPPFLAGS="" CFLAGS="-pipe -O0 -g3 -ggdb -Wall -fstrict-aliasing -fdiagnostics-color=auto -g -O0" LDFLAGS="-L/home/philip/Development/gnome/install/lib " CC="gcc" PKG_CONFIG="/usr/bin/pkg-config" DLLTOOL="false"  /home/philip/Development/gnome/install/bin/g-ir-scanner   --namespace=Goa --nsversion=1.0 --libtool="/bin/sh ../../libtool" --pkg=glib-2.0 --pkg=gobject-2.0 --pkg=gio-2.0 --include=Gio-2.0 --pkg-export=goa-1.0   --library=goa-1.0 --c-include='goa/goa.h' --cflags-begin -I../../src -I/home/philip/Development/gnome/source/gnome-online-accounts/src -I../../src/goa -DG_LOG_DOMAIN=\"Goa\" -DGOA_COMPILATION -DPACKAGE_LIBEXEC_DIR=\""/home/philip/Development/gnome/install/libexec"\" -DPACKAGE_SYSCONF_DIR=\""/home/philip/Development/gnome/install/etc"\" -DPACKAGE_DATA_DIR=\""/home/philip/Development/gnome/install/share/gnome-online-accounts"\" -DPACKAGE_BIN_DIR=\""/home/philip/Development/gnome/install/bin"\" -DPACKAGE_LOCALSTATE_DIR=\""/home/philip/Development/gnome/install/var"\" -DPACKAGE_LOCALE_DIR=\""/home/philip/Development/gnome/install/share/locale"\" -DPACKAGE_LIB_DIR=\""/home/philip/Development/gnome/install/lib"\" -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT -w   -pthread -I/home/philip/Development/gnome/install/include/gio-unix-2.0/ -I/home/philip/Development/gnome/install/include/glib-2.0 -I/home/philip/Development/gnome/install/lib/glib-2.0/include  --cflags-end  /home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goa.h /home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaclient.h /home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaerror.h /home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaenums.h goaenumtypes.h /home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaversion.h goa-generated.h /home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaclient.c /home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaerror.c goa-generated.c goaenumtypes.c /home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaversion.c libgoa-1.0.la --output Goa-1.0.gir
/home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaclient.h:32: syntax error, unexpected ';' in '# 32 "/home/philip/Development/gnome/source/gnome-online-accounts/src/goa/goaclient.h"' at ';'

(In reply to Philip Withnall from comment #5)
> It’s happening inside the g-ir-scanner execution.

Oh, right. I remember seeing it before. I was hoping that g-ir-scanner would improve, but since I am not going to do that myself, let's drop the trailing semicolon instead. :)