GNOME Bugzilla – Bug 785631
ptpclock: build failure when undefining USE_MEASUREMENT_FILTERING
Last modified: 2018-01-26 11:27:35 UTC
building gstptpclock.c without USE_MEASUREMENT_FILTERING fail because out is not defined. I suggest to apply the following patch diff --git a/libs/gst/net/gstptpclock.c b/libs/gst/net/gstptpclock.c index 2f669891d..744507688 100644 --- a/libs/gst/net/gstptpclock.c +++ b/libs/gst/net/gstptpclock.c @@ -1401,11 +1406,11 @@ update_mean_path_delay (PtpDomainData * domain, PtpPendingSync * sync) GST_TIME_FORMAT ")", domain->domain, GST_TIME_ARGS (domain->mean_path_delay), GST_TIME_ARGS (mean_path_delay)); GST_DEBUG ("Delay request delay for domain %u: %" GST_TIME_FORMAT, domain->domain, GST_TIME_ARGS (delay_req_delay)); -#ifdef USE_MEASUREMENT_FILTERING +#if defined(USE_MEASUREMENT_FILTERING) || defined(USE_MEDIAN_PRE_FILTERING) out: #endif
Thanks, can you provide the patch in "git format-patch" format? See https://gstreamer.freedesktop.org/documentation/contribute/#how-to-submit-patches
Created attachment 356689 [details] [review] [PATCH] ptp: fix fail to build undifing USE_MEASUREMENT_FILTERING [PATCH] ptp: fix fail to build undifing USE_MEASUREMENT_FILTERING
I add the patch in git format plus another minor cosmetic change to avoid failure of pre-commit hook
Thanks, sorry it took so long to get this in: commit 0af74cb599e917b7c090800d67bded853d5d5e1a Author: Michele Dionisio <michele.dionisio@gmail.com> Date: Tue Aug 1 10:43:32 2017 +0200 ptp: fix build failure with #undef USE_MEASUREMENT_FILTERING "Label ‘out’ used but not defined", since it's also used by the USE_MEDIAN_PRE_FILTERING branch. https://bugzilla.gnome.org/show_bug.cgi?id=785631