After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785631 - ptpclock: build failure when undefining USE_MEASUREMENT_FILTERING
ptpclock: build failure when undefining USE_MEASUREMENT_FILTERING
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.x
Other All
: Normal normal
: 1.12.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-31 13:40 UTC by Michele Dionisio
Modified: 2018-01-26 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] ptp: fix fail to build undifing USE_MEASUREMENT_FILTERING (1.14 KB, patch)
2017-08-01 08:46 UTC, Michele Dionisio
committed Details | Review

Description Michele Dionisio 2017-07-31 13:40:20 UTC
building gstptpclock.c without USE_MEASUREMENT_FILTERING fail because out is not defined.

I suggest to apply the following patch

diff --git a/libs/gst/net/gstptpclock.c b/libs/gst/net/gstptpclock.c
index 2f669891d..744507688 100644
--- a/libs/gst/net/gstptpclock.c
+++ b/libs/gst/net/gstptpclock.c
@@ -1401,11 +1406,11 @@ update_mean_path_delay (PtpDomainData * domain, PtpPendingSync * sync)
       GST_TIME_FORMAT ")", domain->domain,
       GST_TIME_ARGS (domain->mean_path_delay), GST_TIME_ARGS (mean_path_delay));
   GST_DEBUG ("Delay request delay for domain %u: %" GST_TIME_FORMAT,
       domain->domain, GST_TIME_ARGS (delay_req_delay));
 
-#ifdef USE_MEASUREMENT_FILTERING
+#if defined(USE_MEASUREMENT_FILTERING) || defined(USE_MEDIAN_PRE_FILTERING)
 out:
 #endif
Comment 1 Sebastian Dröge (slomo) 2017-07-31 15:36:03 UTC
Thanks, can you provide the patch in "git format-patch" format? See https://gstreamer.freedesktop.org/documentation/contribute/#how-to-submit-patches
Comment 2 Michele Dionisio 2017-08-01 08:46:32 UTC
Created attachment 356689 [details] [review]
[PATCH] ptp: fix fail to build undifing USE_MEASUREMENT_FILTERING

[PATCH] ptp: fix fail to build undifing USE_MEASUREMENT_FILTERING
Comment 3 Michele Dionisio 2017-08-01 08:47:25 UTC
I add the patch in git format plus another minor cosmetic change to avoid failure of pre-commit hook
Comment 4 Tim-Philipp Müller 2018-01-18 17:47:32 UTC
Thanks, sorry it took so long to get this in:

commit 0af74cb599e917b7c090800d67bded853d5d5e1a
Author: Michele Dionisio <michele.dionisio@gmail.com>
Date:   Tue Aug 1 10:43:32 2017 +0200

    ptp: fix build failure with #undef USE_MEASUREMENT_FILTERING
    
    "Label ‘out’ used but not defined", since it's also used by
    the USE_MEDIAN_PRE_FILTERING branch.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=785631