After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785585 - Update Xml.ParserOption (libxml-2.0.vapi)
Update Xml.ParserOption (libxml-2.0.vapi)
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-30 05:28 UTC by kosmolot17
Modified: 2017-08-02 07:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch updating Xml.ParserOption (701 bytes, patch)
2017-08-01 14:38 UTC, kosmolot17 		none Details | Review
A patch updating Xml.ParserOption (typo fixed) (703 bytes, patch)
2017-08-02 03:57 UTC, kosmolot17 		committed Details | Review

Description kosmolot17 2017-07-30 05:28:45 UTC 
Current Xml.ParserOption has only: RECOVER, NOENT, ..., COMPACT

http://xmlsoft.org/html/libxml-parser.html#xmlParserOption

Aaccording to the above, these items should be added:
    OLD10,
    OBASEFIX,
    HUGE,
    OLDSAX,
    IGNORE_ENC,
    BIG_LINES
Comment 1 Al Thomas 2017-07-31 10:17:11 UTC 
Thanks for the report. libxml-2.0.vapi is maintained manually so it should be fairly easy to generate a patch. Can you do so?
Comment 2 kosmolot17 2017-08-01 14:38:48 UTC 
Created attachment 356741 [details] [review]
A patch updating Xml.ParserOption
Comment 3 Al Thomas 2017-08-01 14:55:00 UTC 
Review of attachment 356741 [details] [review]:

Thanks! Looks like there is a typo: should be NOBASEFIX instead of OBASEFIX?

Also we generally prefer a persons full name for the commit log rather than a nick name.
Comment 4 kosmolot17 2017-08-02 03:46:33 UTC 
Comment on attachment 356741 [details] [review]
A patch updating Xml.ParserOption

>From b003e17fb83bd14422c82eb3ec70e146d33472d7 Mon Sep 17 00:00:00 2001
>From: kosmolot <kosmolot17@yandex.com>
>Date: Tue, 1 Aug 2017 23:28:34 +0900
>Subject: [PATCH] Update libxml-2.0.vapi
>
>---
> vapi/libxml-2.0.vapi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/vapi/libxml-2.0.vapi b/vapi/libxml-2.0.vapi
>index d027a4186..a6f182936 100644
>--- a/vapi/libxml-2.0.vapi
>+++ b/vapi/libxml-2.0.vapi
>@@ -210,6 +210,12 @@ namespace Xml {
> 		NOCDATA,
> 		NOXINCNODE,
> 		COMPACT,
>+		OLD10,
>+		NOBASEFIX,
>+		HUGE,
>+		OLDSAX,
>+		IGNORE_ENC,
>+		BIG_LINES,
> 	}
> 
> 	[CCode (cname = "xmlCharEncoding", cprefix = "XML_CHAR_ENCODING_", cheader_filename = "libxml/encoding.h", has_type_id = false)]
>-- 
>2.13.3
>
Comment 5 kosmolot17 2017-08-02 03:57:51 UTC 
Created attachment 356761 [details] [review]
A patch updating Xml.ParserOption (typo fixed)