GNOME Bugzilla – Bug 785574
banshee asks for a 128x128 multimedia-player icon, but uses a 512x512 unscaled one instead
Last modified: 2017-11-20 10:43:55 UTC
In Fedora 25, with adwaita-icon-theme-3.22, banshee uses the 256x256/devices/multimedia-player.png file scaled at size 128x128. But this icon has been removed in 3.24, and in Fedora 26, banshee now uses the huge 512x512 icon instead (this one is not scaled down, because this category is marked with Type=Fixed). This icon is used in banshee in the main window, when plugging an usb media player for example. https://bugzilla.redhat.com/show_bug.cgi?id=1475534
256x256/mimetypes/audio-x-generic.png is also concerned BTW. This is the icon used below the libraries and devices list in the main window.
Created attachment 360447 [details] [review] 512 mistakenly not scalable - during the 256 > 512 transition, the automake system wasn't updated to mark the 512 size as scalable, thus some lower sizes were handled by 48x48 or icons appeared giant (512 nominal size).
Attachment 360447 [details] pushed as 824af3c - 512 mistakenly not scalable
It would be awesome if this could be pushed to the 3-26 stable branch and a 3.26.1 release made after, so I don't have to wait for 3.28 Pretty please with sugar on top :-)
Jakub the fix won't work, it fixes 512x512, setting them to 'scalable', but breaks 256x256 which became 'fixed'. I'm not on the right machine to fix this, anyway the test statement you changed should be something like: test "$$size" = "256" -o "$$size" = "512"
Uhm, nope, the max size won't do for 256, forget about my last comment. It needs a different fix.
Pushed a fix to both master and 3.26, closing.