Bug 785562 – crash when undoing a rename from search

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 785562 - crash when undoing a rename from search


Summary:	crash when undoing a rename from search


Status:	RESOLVED FIXED

Product:	nautilus
Classification:	Core
Component:	File and Folder Operations
Version:	3.26.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Nautilus Maintainers
QA Contact:	Nautilus Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-07-29 15:13 UTC by Hussam Al-Tayeb
Modified:	2017-08-07 10:50 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
file: clear info before removing from directory (1.49 KB, patch) 2017-07-30 10:22 UTC, Ernestas Kulik	committed	Details \| Review

Description Hussam Al-Tayeb 2017-07-29 15:13:27 UTC

I searched for a word and it resulted in two files.
one is myfile.txt and the other is my secondfile.png
I wanted to rename myfile.txt to secondfile.txt
I clicked f2 on secondfile.png to copy its name but I accidentally clicked ctrl x instead of ctrl c.
I'm not sure what else I clicked on next but it was ctrl something.
Then nautilus crashed. no files where renamed. there was no data loss.

I tried a few times again to guess what the last step was but couldn't reproduce.

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
Core was generated by `/usr/bin/nautilus --gapplication-service'.
Program terminated with signal SIGSEGV, Segmentation fault.

+ Trace 237727

Thread 7 (Thread 0x7f113d6c2700 (LWP 19746))

#0 syscall
#1 g_cond_wait_until
at gthread-posix.c line 1442
#2 g_async_queue_pop_intern_unlocked
at gasyncqueue.c line 422
#3 g_async_queue_timeout_pop_unlocked
at gasyncqueue.c line 570
#4 g_thread_pool_wait_for_new_task
at gthreadpool.c line 262
#5 g_thread_pool_thread_proxy
at gthreadpool.c line 296
#6 g_thread_proxy
at gthread.c line 784
#7 start_thread
#8 clone

Thread 4 (Thread 0x7f113dec3700 (LWP 19744))

#0 syscall
#1 g_cond_wait
at gthread-posix.c line 1395
#2 g_async_queue_pop_intern_unlocked
at gasyncqueue.c line 419
#3 g_async_queue_pop
at gasyncqueue.c line 453
#4 tracker_direct_connection_thread_func
at /home/hussam/cache/gnome/tracker/src/tracker/src/libtracker-direct/tracker-direct.vala line 151
#5 _tracker_direct_connection_thread_func_gthread_func
at tracker-direct.c line 1136
#6 g_thread_proxy
at gthread.c line 784
#7 start_thread
#8 clone

Thread 2 (Thread 0x7f112bfff700 (LWP 19760))

#0 syscall
#1 g_cond_wait_until
at gthread-posix.c line 1442
#2 g_async_queue_pop_intern_unlocked
at gasyncqueue.c line 422
#3 g_async_queue_timeout_pop_unlocked
at gasyncqueue.c line 570
#4 g_thread_pool_wait_for_new_task
at gthreadpool.c line 262
#5 g_thread_pool_thread_proxy
at gthreadpool.c line 296
#6 g_thread_proxy
at gthread.c line 784
#7 start_thread
#8 clone

Thread 1 (Thread 0x7f11618c59c0 (LWP 1610))

#0 nautilus_file_clear_info
at ../src/nautilus-file.c line 474
#1 rename_get_info_callback
at ../src/nautilus-file.c line 1964
#2 g_task_return_now
at gtask.c line 1145
#3 complete_in_idle_cb
at gtask.c line 1159
#4 g_main_dispatch
at gmain.c line 3148
#5 g_main_context_dispatch
at gmain.c line 3813
#6 g_main_context_iterate
at gmain.c line 3886
#7 g_main_context_iteration
at gmain.c line 3947
#8 g_application_run
at gapplication.c line 2401
#9 main
at ../src/nautilus-main.c line 102

Comment 1 Ernestas Kulik 2017-07-30 07:46:14 UTC

Confirming. This happens when pressing ^Z while in search.

Comment 2 Ernestas Kulik 2017-07-30 07:49:09 UTC

(In reply to Ernestas Kulik from comment #1)
> Confirming. This happens when pressing ^Z while in search.

Actually, it happened just now again and I wasn’t searching.

Comment 3 Ernestas Kulik 2017-07-30 07:49:49 UTC

(In reply to Ernestas Kulik from comment #2)
> (In reply to Ernestas Kulik from comment #1)
> > Confirming. This happens when pressing ^Z while in search.
> 
> Actually, it happened just now again and I wasn’t searching.

Actually, nevermind, it’s just a breakpoint. Sorry for the spam.

Comment 4 Ernestas Kulik 2017-07-30 10:22:48 UTC

Created attachment 356588 [details] [review]
file: clear info before removing from directory

When marking the file as gone, clearing its file info after removing it
from the parent directory will result in a crash in cases where it is
the last reference being dropped.

Comment 5 Carlos Soriano 2017-08-07 10:44:10 UTC

Review of attachment 356588 [details] [review]:

Nice catch, LGTM!

Comment 6 Ernestas Kulik 2017-08-07 10:50:44 UTC

Attachment 356588 [details] pushed as d1876bd - file: clear info before removing from directory