After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785524 - Fix the Flatpak build
Fix the Flatpak build
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-07-28 13:10 UTC by Mathieu Bridon
Modified: 2017-08-01 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flatpak: Install totem-pl-parser in the right place (819 bytes, patch)
2017-07-28 13:10 UTC, Mathieu Bridon 		none Details | Review
flatpak: Build gom with meson (881 bytes, patch)
2017-07-28 13:10 UTC, Mathieu Bridon 		none Details | Review
flatpak: Build Totem with meson (885 bytes, patch)
2017-07-28 13:10 UTC, Mathieu Bridon 		none Details | Review
flatpak: Install totem-pl-parser in the right place (929 bytes, patch)
2017-07-28 22:53 UTC, Mathieu Bridon 		committed Details | Review
flatpak: Build gom with meson (881 bytes, patch)
2017-07-28 22:53 UTC, Mathieu Bridon 		committed Details | Review
flatpak: Build Totem with meson (885 bytes, patch)
2017-07-28 22:53 UTC, Mathieu Bridon 		committed Details | Review

Description Mathieu Bridon 2017-07-28 13:10:31 UTC 
.
Comment 1 Mathieu Bridon 2017-07-28 13:10:36 UTC 
Created attachment 356510 [details] [review]
flatpak: Install totem-pl-parser in the right place
Comment 2 Mathieu Bridon 2017-07-28 13:10:44 UTC 
Created attachment 356511 [details] [review]
flatpak: Build gom with meson
Comment 3 Mathieu Bridon 2017-07-28 13:10:51 UTC 
Created attachment 356512 [details] [review]
flatpak: Build Totem with meson
Comment 4 Mathieu Bridon 2017-07-28 13:13:58 UTC 
After these 3 patches Totem still doesn't build, because it needs a newer Meson than what's in the Sdk.

I'll see whether we can upgrade Meson in the Sdk, or whether we'll need to find another solution.
Comment 5 Bastien Nocera 2017-07-28 15:27:19 UTC 
Review of attachment 356510 [details] [review]:

Where was it installing before? Can you please add this information in the commit message?
Comment 6 Bastien Nocera 2017-07-28 15:28:25 UTC 
Review of attachment 356511 [details] [review]:

Yes.
Comment 7 Bastien Nocera 2017-07-28 15:29:03 UTC 
Review of attachment 356512 [details] [review]:

Duh!
Comment 8 Mathieu Bridon 2017-07-28 22:53:15 UTC 
Created attachment 356534 [details] [review]
flatpak: Install totem-pl-parser in the right place

By default, Meson uses /usr/lib64 as libdir in Flatpak, but we really
want everything installed in /usr/lib.
Comment 9 Mathieu Bridon 2017-07-28 22:53:21 UTC 
Created attachment 356535 [details] [review]
flatpak: Build gom with meson
Comment 10 Mathieu Bridon 2017-07-28 22:53:25 UTC 
Created attachment 356536 [details] [review]
flatpak: Build Totem with meson
Comment 11 Bastien Nocera 2017-08-01 14:47:51 UTC 
Review of attachment 356534 [details] [review]:

Yep!
Comment 12 Bastien Nocera 2017-08-01 14:48:35 UTC 
Review of attachment 356535 [details] [review]:

Yep.
Comment 13 Bastien Nocera 2017-08-01 14:49:02 UTC 
Review of attachment 356536 [details] [review]:

Yup yup.
Comment 14 Mathieu Bridon 2017-08-01 15:54:54 UTC 
Attachment 356534 [details] pushed as bc13dc3 - flatpak: Install totem-pl-parser in the right place
Attachment 356535 [details] pushed as ae02067 - flatpak: Build gom with meson
Attachment 356536 [details] pushed as eae1ce1 - flatpak: Build Totem with meson