GNOME Bugzilla – Bug 785490
hard to see the bookmark icon in the address bar
Last modified: 2018-07-27 12:23:01 UTC
Created attachment 356463 [details] screenshot Maybe it's only my monitor, but the bookmarks icon is a bit hard to see, due to the low contrast between the specific yellow used and the white background color of the address bar.
You're right, I guess it is a little hard to see. Any chance you could recommend a different shade of yellow? I'm not actually sure if Epiphany is coloring the icon itself. Probably.
Created attachment 357989 [details] Demonstrating various Tango colours
Created attachment 357990 [details] [review] Change bookmark icon colour from yellow to blue The current bookmark icon colour, #fce94f, is the first in the Butter colour range from the Tango Icon Theme Guidelines: http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines In the screenshot I previously attached, you can see how I experimented with each of the recommended colours. Personally, I feel that any yellow on white is a bad idea. Blue however seems much more legible, and it seems Chromium and Firefox do the same. This patch contains the change, where I've coloured it #729fcf, the first in the Sky Blue range. It looks good with GNOME's Night Light feature enabled too. Let me know what you think. Thanks!
I'm fine with changing the bookmarks star icon to sky blue. My only concern is that blue is not really a color that would normally be associated with stars. Andreas, are you OK with this change? I'll CC a couple more folks from design team as well in case someone wants to object. #edd400 looks OK to me too.
I always liked to original bordered star that was also in the mock-ups [1]. I do not remember why we changed it, but I think it had something to do with using the already present symbolic version we have in adwaita. Maybe we should go back to that? [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/web/web-bookmarks-and-header-bar-wires.png
Hmmm I would really hesitate to use a non-symbolic icon here. Just giving it a border seems fine, if that's possible to do with the CSS.
(In reply to Michael Catanzaro from comment #4) > I'm fine with changing the bookmarks star icon to sky blue. My only concern > is that blue is not really a color that would normally be associated with > stars. Andreas, are you OK with this change? I'll CC a couple more folks > from design team as well in case someone wants to object. > > #edd400 looks OK to me too. Blue gives a good contrast, so it sounds like a good color to me. Firefox uses a blue star for bookmarks. Edge [2] and Safari [3], uses blue outlined stars in menus. 1. http://pad3.whstatic.com/images/thumb/e/ea/Bookmark-a-Page-in-Mozilla-Firefox-Step-3-Version-3.jpg/aid137284-v4-728px-Bookmark-a-Page-in-Mozilla-Firefox-Step-3-Version-3.jpg 2. https://www.tenforums.com/attachments/tutorials/22054d1434841314-add-remove-microsoft-edge-favorites-windows-10-a-microsoft_edge_favorites-6b.png 3. https://www.howtogeek.com/wp-content/uploads/2013/11/xsafari-bookmarks-on-ipad.png.pagespeed.gp+jp+jw+pj+ws+js+rj+rp+rw+ri+cp+md.ic.4VeiHqkHDV.png
Michael, can we add this one now?
Comment on attachment 357990 [details] [review] Change bookmark icon colour from yellow to blue No, I want to stick with yellow. It's a star!
It's orange now.