GNOME Bugzilla – Bug 785453
gnome-disk couldn't edit mount option for swap partition
Last modified: 2017-09-18 11:39:12 UTC
Created attachment 356435 [details] screenshot gnome-disk couldn't edit mount option for swap partition.
Without editing mount option is impossible make swap partition permanent by GUI.
Created attachment 356744 [details] [review] Show mount options for swap volumes Thanks for reporting this, here is a patch pending to be reviewed.
Review of attachment 356744 [details] [review]: Hmm, ok, but we have to do something also with the prefilled mount options. I would say that "Show in user interface", "Display Name", "Icon Name" etc. don't make sense at all for swap... ::: src/disks/gdufstabdialog.c @@ +411,3 @@ data.symbolic_icon_entry = GTK_WIDGET (gtk_builder_get_object (builder, "fstab-symbolic-icon-entry")); + data.is_swap = udisks_object_peek_swapspace (object) != NULL; data.is_swap = (udisks_object_peek_swapspace (object) != NULL);
Created attachment 357575 [details] [review] Show mount options for swap volumes The other irrelevant entries are now insensitive as well.
Review of attachment 357575 [details] [review]: Thanks for update. Does swap work correctly with "auto" filesystem type? ::: src/disks/gdufstabdialog.c @@ +460,3 @@ + dir = "none"; + gtk_widget_set_sensitive (data.directory_entry, FALSE); + gtk_widget_set_sensitive (data.show_checkbutton, FALSE); Yes, but you have to change also the default options, which currently contains the following: opts = "nosuid,nodev,nofail,x-gvfs-show"; Also not sure about the other options...
Created attachment 357673 [details] [review] Show mount options for swap volumes Good that you've spotted this, I think these defaults are better now.
Review of attachment 357673 [details] [review]: Looks ok.