After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785451 - libwnck-3.24.0 breaks pin_window for devilspie
libwnck-3.24.0 breaks pin_window for devilspie
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-26 16:46 UTC by Jose Marino
Modified: 2017-07-27 11:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: ensure that ALL_WORKSPACES has the X11 expected value (764 bytes, patch)
2017-07-27 11:36 UTC, Marco Trevisan (Treviño) 		committed Details | Review

Description Jose Marino 2017-07-26 16:46:51 UTC 
I'm running cinnamon desktop (3.4.4) on Archlinux. I use devilspie to automatically show certain windows on all workspaces.
After updating libwnck from 3.20.1 to 3.24.0 the "pin_window" function in devilspie (which calls "wnck_window_pin") stopped working. Devilspie fails to make windows show in all workspaces without printing any errors.
However, things work as expected when making windows visible on all workspaces using the context menus provided by the desktop. I.e., right click on window title and selecting "Always on Visible Workspace" makes the window visible in all workspaces.

A bisect of libwnck from 3.20.1 to 3.24.0 found this:
4eea6ce25673167b109d9fad3ee1224caa92dd79 is the first bad commit
commit 4eea6ce25673167b109d9fad3ee1224caa92dd79
Author: Alberts Muktupāvels <alberts.muktupavels@gmail.com>
Date:   Sat Apr 29 11:43:14 2017 +0300

    window: avoid signed / unsigned warning

I have reverted commit 4eea6ce on top of 3.24.0 and I can confirm that reverting the commit makes devilspie's "pin_window" function work again.

I have tested the original devilspie and the newer devilspie2. Both call function "wnck_window_pin" and they both display this problem.
Comment 1 Marco Trevisan (Treviño) 2017-07-27 11:36:09 UTC 
Created attachment 356470 [details] [review]
window: ensure that ALL_WORKSPACES has the X11 expected value

And cast it explicitly so that we mute warnings
Comment 2 Marco Trevisan (Treviño) 2017-07-27 11:37:18 UTC 
Attachment 356470 [details] pushed as 3baa3da - window: ensure that ALL_WORKSPACES has the X11 expected value