After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785449 - [review] pt1 of fixing route caching in platform [th/platform-route-pt1-bgo785449]
[review] pt1 of fixing route caching in platform [th/platform-route-pt1-bgo78...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-07-26 15:34 UTC by Thomas Haller
Modified: 2017-08-03 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2017-07-26 15:34:50 UTC 
See https://bugzilla.redhat.com/show_bug.cgi?id=1337855 for why.

This is a first part, towards getting route caching right. More to come later.


Please review.
Comment 1 Beniamino Galvani 2017-08-02 12:52:37 UTC 
"make check" fails:

 NetworkManager:ERROR:src/tests/test-route-manager.c:774:test_ip6: assertion failed (routes->len == G_N_ELEMENTS (state2)): (8 == 7)


> platform: print lock paramters of route

src/platform/nm-platform.c: In function ‘nm_platform_ip4_route_to_string’:
src/platform/nm-platform.c:4212:30: error: logical ‘or’ of equal expressions [-Werror=logical-op]
              route->cwnd     || route->cwnd          ? nm_sprintf_buf (str_cwnd,     " cwnd %s%"G_GUINT32_FORMAT,     route->lock_cwnd     ? "lock " : "", route->cwnd)     : "",
                              ^~
src/platform/nm-platform.c: In function ‘nm_platform_ip6_route_to_string’:
src/platform/nm-platform.c:4281:30: error: logical ‘or’ of equal expressions [-Werror=logical-op]
              route->cwnd     || route->cwnd          ? nm_sprintf_buf (str_cwnd,     " cwnd %s%"G_GUINT32_FORMAT,     route->lock_cwnd     ? "lock " : "", route->cwnd)     : "",
                              ^~
Comment 2 Thomas Haller 2017-08-02 13:38:56 UTC 
(In reply to Beniamino Galvani from comment #1)
> "make check" fails:
> 
>  NetworkManager:ERROR:src/tests/test-route-manager.c:774:test_ip6: assertion
> failed (routes->len == G_N_ELEMENTS (state2)): (8 == 7)

the last commit is not yet finished. Much more work missing there. All previous commits should be correct though.


> > platform: print lock paramters of route
> 
> src/platform/nm-platform.c: In function ‘nm_platform_ip4_route_to_string’:
> src/platform/nm-platform.c:4212:30: error: logical ‘or’ of equal expressions
> [-Werror=logical-op]
>               route->cwnd     || route->cwnd          ? nm_sprintf_buf
> (str_cwnd,     " cwnd %s%"G_GUINT32_FORMAT,     route->lock_cwnd     ? "lock
> " : "", route->cwnd)     : "",

fixed and repushed.
Comment 3 Thomas Haller 2017-08-03 17:07:06 UTC 
merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=6da63230801cadd978d4a992e6825c5c2adc3324


this was only another, smaller preparation branch for the larger rework of route handling.