GNOME Bugzilla – Bug 785364
Add toggle for disabling thumbnailers
Last modified: 2021-06-09 16:00:58 UTC
gnome-desktop follows a setting in gsettings-desktop-schemas to disable running thumbnailers. We should have a GUI control to turn it off.
Created attachment 356340 [details] [review] privacy: Add a toggle for all thumbnailers
Created attachment 356341 [details] [review] privacy: Add a toggle for all thumbnailers
Created attachment 356342 [details] thumbnailers disable
Review of attachment 356341 [details] [review]: otherwise looks fine, if UI has been reviewed feel free to push ::: panels/privacy/cc-privacy-panel.c @@ +69,3 @@ guint abrt_watch_id; + GtkWidget *thumbnailers_dialog; unused @@ +1412,3 @@ self->priv->notification_settings = g_settings_new ("org.gnome.desktop.notifications"); self->priv->location_settings = g_settings_new ("org.gnome.system.location"); + self->priv->thumbnailers_settings = g_settings_new ("org.gnome.desktop.thumbnailers"); needs to be freed on finalize
Created attachment 356383 [details] [review] privacy: Add a toggle for all thumbnailers
Review of attachment 356383 [details] [review]: ++
Review of attachment 356383 [details] [review]: <aday[m]> hadess: the setting is going to break a fair amount of stuff; it would be better to find a way to keep some thumbnailing while mitigating the privacy implications. that said, if we do want it i'd probably want to integrate it into the existing usage/history/trash/temp files settings rather than growing a whole new "turn off thumbnails" thing - better to group these things logically rather than grow controls for technical details
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.