GNOME Bugzilla – Bug 785298
Page saved as HTML, no matter what file extension one gives (except .mhtml)
Last modified: 2018-08-03 21:12:30 UTC
C-s to save a file works fine if the user doesn't change the mhtml extension. If he does, the file will be saved as html, no matter what the extension the user changes gives. .txt, .zzz, whatever. Also the user has no way to know that the valid types he can pick are mhtml and html.
Hm, good find. I almost think it should always be saved as an MHTML, but I suppose it's harmless to leave the HTML option for anyone clever enough to try changing the file extension. But that's rarely ever what you want, because then you only get the main resource and not the entire webpage.
Could you guys get into the practice of linking the changesets you make to the bug report when marking something as FIXED. Thanks.
Here's the change: https://git.gnome.org/browse/epiphany/commit/?id=77626e20a6e4c312761e7f75184e26ae17a65552 git-bz is supposed to attach the patch and post a link when it closes the bug. It usually works... sometimes it just doesn't.
This introduced bug #788111. Reverted and reopening.
The following fix has been pushed: 96d71ce Revert "web-view: Save as MHTML by default"
Created attachment 360331 [details] [review] Revert "web-view: Save as MHTML by default" This reverts commit 77626e20a6e4c312761e7f75184e26ae17a65552. Broke saving of plaintext files
Note: (In reply to Michael Gratton from comment #5) > The Bug 785298 version would would fine if the expression also check if the > context type of the main resource is not "text/html", so the else block is > only ever executed if the main resource is actually a web page?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/412.