After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785277 - crash in gnome-shell caused by a null timezone in update_clock()
crash in gnome-shell caused by a null timezone in update_clock()
Status: RESOLVED DUPLICATE of bug 780861
Product: gnome-desktop
Classification: Core
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-22 16:00 UTC by Fabrice Bellet
Modified: 2017-07-25 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdb backtrace of the crash (3.39 KB, text/plain)
2017-07-22 16:00 UTC, Fabrice Bellet 		  Details
wall-clock: properly disconnect a signal handler (gnome-3-24 branch) (1.83 KB, patch)
2017-07-25 11:28 UTC, Fabrice Bellet 		none Details | Review
wall-clock: properly disconnect a signal handler (master branch) (1.82 KB, patch)
2017-07-25 11:30 UTC, Fabrice Bellet 		none Details | Review

Description Fabrice Bellet 2017-07-22 16:00:20 UTC 
Created attachment 356180 [details]
gdb backtrace of the crash

The bug occurs here when self->priv->timezone is null in update_clock().
Comment 1 Fabrice Bellet 2017-07-25 11:28:29 UTC 
Created attachment 356351 [details] [review]
wall-clock: properly disconnect a signal handler (gnome-3-24 branch)

I think the problem is that the signal handler still exists after the gnomewallclock object is disposed, and uses the gnomewallclock object from the user data. This patch disconnects the signal handler in the dispose method. I played with it since a couple of days and could not trigger this crash again.
Comment 2 Fabrice Bellet 2017-07-25 11:30:13 UTC 
Created attachment 356352 [details] [review]
wall-clock: properly disconnect a signal handler (master branch)
Comment 3 Rui Matos 2017-07-25 13:53:34 UTC 
Thanks for the patch, we already know about this, see bug 780861 .

Perhaps we should indeed push the patch in https://bugzilla.gnome.org/show_bug.cgi?id=780861#c0 since glib hasn't been fixed yet and people keep hitting this in the wild. Bastien?

*** This bug has been marked as a duplicate of bug 780861 ***