After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785269 - grokjpeg2000enc/grokjpeg2000dec: develop plugin for Grok JPEG 2000 codec
grokjpeg2000enc/grokjpeg2000dec: develop plugin for Grok JPEG 2000 codec
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-22 11:41 UTC by Aaron Boxer
Modified: 2018-11-03 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
grokenc/grokdec: add plugins to support Grok JPEG 2000 library (77.63 KB, patch)
2017-07-22 13:03 UTC, Aaron Boxer
none Details | Review
grokenc/grokdec: add plugins to support Grok JPEG 2000 library (77.52 KB, patch)
2017-07-22 13:47 UTC, Aaron Boxer
none Details | Review
grokjpeg2000enc/grokjpeg2000dec: add plugins to support Grok JPEG 2000 library (79.25 KB, patch)
2017-07-23 04:07 UTC, Aaron Boxer
none Details | Review
grokjpeg2000enc/grokjpeg2000dec: add plugins to support Grok JPEG 2000 library (79.66 KB, patch)
2017-07-23 04:20 UTC, Aaron Boxer
none Details | Review
grokjpeg2000enc/grokjpeg2000dec: add plugins to support Grok JPEG 2000 library (79.98 KB, patch)
2017-09-03 13:37 UTC, Aaron Boxer
none Details | Review

Description Aaron Boxer 2017-07-22 11:41:10 UTC
Grok is an open source JPEG 2000 codec, licensed under the AGPL

https://github.com/GrokImageCompression/grok

The API is currently a super-set of the OpenJPEG API, and is currently a drop-in replacement for OpenJPEG. It currently works with the openjpegenc/openjpegdec plugins.  

I am planning on adding asynchronous encode/decode to make better use of multi-core. So, the library will need its own plugin.

The plugin itself will be licensed under the LGPL, following the guidelines here:

https://gstreamer.freedesktop.org/documentation/licensing.html
Comment 1 Aaron Boxer 2017-07-22 12:56:40 UTC
A pipeline for testing:

gst-launch-1.0 -v videotestsrc ! grokenc ! jpeg2000parse ! mpegtsmux ! rtpmp2tpay ! rtpmp2tdepay ! tsdemux ! jpeg2000parse ! grokdec ! videoconvert ! ximagesink
Comment 2 Aaron Boxer 2017-07-22 13:03:30 UTC
Created attachment 356175 [details] [review]
grokenc/grokdec: add plugins to support Grok JPEG 2000 library
Comment 3 Aaron Boxer 2017-07-22 13:47:12 UTC
Created attachment 356177 [details] [review]
grokenc/grokdec: add plugins to support Grok JPEG 2000 library
Comment 4 Nicolas Dufresne (ndufresne) 2017-07-22 23:27:09 UTC
I would like to suggest grokj2kdec/enc or grokjpeg2000dec/enc, will be easier for those that don't know grok.
Comment 5 Aaron Boxer 2017-07-23 03:59:44 UTC
(In reply to Nicolas Dufresne (stormer) from comment #4)
> I would like to suggest grokj2kdec/enc or grokjpeg2000dec/enc, will be
> easier for those that don't know grok.

Good idea.
Comment 6 Aaron Boxer 2017-07-23 04:07:13 UTC
Created attachment 356219 [details] [review]
grokjpeg2000enc/grokjpeg2000dec: add plugins to support Grok JPEG 2000 library

Name change, and some other fixes.
Comment 7 Aaron Boxer 2017-07-23 04:08:22 UTC
This pipeline now working for testing:

gst-launch-1.0 -v videotestsrc ! grokjpeg2000enc ! jpeg2000parse ! mpegtsmux ! rtpmp2tpay ! rtpmp2tdepay ! tsdemux ! jpeg2000parse ! grokjpeg2000dec ! videoconvert ! ximagesink
Comment 8 Aaron Boxer 2017-07-23 04:20:39 UTC
Created attachment 356221 [details] [review]
grokjpeg2000enc/grokjpeg2000dec: add plugins to support Grok JPEG 2000 library

a little more cleanup
Comment 9 Nicolas Dufresne (ndufresne) 2017-07-23 22:30:52 UTC
Didn't review yet, but I just notice the copyright should be assigned to yourself.
Comment 10 Aaron Boxer 2017-07-24 12:23:20 UTC
Thanks, I will add my name to the copyright message.
Comment 11 Aaron Boxer 2017-09-03 13:37:21 UTC
Created attachment 359021 [details] [review]
grokjpeg2000enc/grokjpeg2000dec: add plugins to support Grok JPEG 2000 library

Updated copyright notice
Comment 12 Aaron Boxer 2017-09-03 13:38:54 UTC
<polite request for a review of this new plugin :) />
Comment 13 GStreamer system administrator 2018-11-03 14:11:29 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/589.