After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785248 - tracker meson build issue with bash_completion
tracker meson build issue with bash_completion
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-07-21 20:02 UTC by Jeremy Bicha
Modified: 2017-07-24 08:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: Fix bash completion dir guessing (1.04 KB, patch)
2017-07-22 09:48 UTC, Carlos Garnacho
committed Details | Review

Description Jeremy Bicha 2017-07-21 20:02:07 UTC
tracker 1.99.1
meson 0.41.2

Build log excerpt
-----------------
Determining dependency 'bash-completion' with pkg-config executable '/usr/bin/pkg-config'
Native dependency bash-completion found: YES 2.1

Meson encountered an error in file meson.build, line 325, column 4:
Unknown method "get_variable" in object.

More info
---------
meson.build has this code snippet:

  if bash_completion_package.found()
    bash_completion_dir = bash_completion_package.get_variable('completionsdir')

but 'completionsdir' isn't defined.
Comment 1 Carlos Garnacho 2017-07-22 09:25:56 UTC
In fedora there is...
$ grep completionsdir /usr/share/pkgconfig/bash-completion.pc 
completionsdir=${prefix}/share/bash-completion/completions

And also upstream (or at least fedora's):
https://github.com/scop/bash-completion/blob/master/bash-completion.pc.in#L3

This is just the same the autotools build has been doing for the last couple of years to figure out the path to install the completion script, and I've seen no other complains. How can we find this out on ubuntu? just hope the path above is right?
Comment 2 Carlos Garnacho 2017-07-22 09:46:50 UTC
Ah I see. It's the get_variable() method itself what fails.
Comment 3 Carlos Garnacho 2017-07-22 09:48:51 UTC
Created attachment 356162 [details] [review]
meson: Fix bash completion dir guessing

Use the right method to fetch a pkg-config variable.
Comment 4 Carlos Garnacho 2017-07-24 08:35:04 UTC
Attachment 356162 [details] pushed as ee6444e - meson: Fix bash completion dir guessing