After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785245 - tracker 1.99.1 fails to build with -Werror=format-security
tracker 1.99.1 fails to build with -Werror=format-security
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
git master
Other Linux
: Normal major
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-07-21 17:58 UTC by Jeremy Bicha
Modified: 2017-07-23 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libtracker-data: fix format-security issue (966 bytes, patch)
2017-07-23 12:12 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-07-21 17:58:57 UTC 
I tried building tracker 1.99.1 on Ubuntu 17.04 but got this error.

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -Wno-unused-variable -Wno-unused-function -Wno-shadow -Wno-format-nonliteral -Wno-sign-compare -Wno-strict-prototypes -DG_LOG_DOMAIN=\"Tracker\" -DTRACKER_COMPILATION -I../../src -I../../src -DSHAREDIR=\"/usr/share\" -pthread -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/uuid -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c tracker-db-manager.c  -fPIC -DPIC -o .libs/tracker-db-manager.o
tracker-db-interface-sqlite.c: In function ‘tracker_db_interface_sqlite_wal_checkpoint’:
tracker-db-interface-sqlite.c:1900:16: error: format not a string literal and no format arguments [-Werror=format-security]
                sqlite3_errstr (return_val));
                ^~~~~~~~~~~~~~
Comment 1 Jeremy Bicha 2017-07-23 12:12:44 UTC 
Created attachment 356227 [details] [review]
libtracker-data: fix format-security issue
Comment 2 Carlos Garnacho 2017-07-23 20:00:16 UTC 
Comment on attachment 356227 [details] [review]
libtracker-data: fix format-security issue

Looks good. Thanks
Comment 3 Jeremy Bicha 2017-07-23 20:36:38 UTC 
Attachment 356227 [details] pushed as 1f39141 - libtracker-data: fix format-security issue