GNOME Bugzilla – Bug 785222
mpegtsmux: generate proper timecode for JPEG 2000 stream using GstVideoTimeCode API
Last modified: 2018-11-03 14:11:16 UTC
Currently we rely on PTS, which is not ideal. Use GstVideoTimeCode instead to generate a correct timecode if there is no meta with an actual timecode on the stream. Also, need to forbid variable frame rate 0/1 in caps See https://bugzilla.gnome.org/show_bug.cgi?id=753323 for (lots!) more details. Also, should document a few of the j2k fields: Fic, Fio, etc.
Alternatively you could also warn only if there are no timecodes / fps==0/1, and just write zero-timecodes. While this is not according to the spec, it should work just fine in most software.
(In reply to Sebastian Dröge (slomo) from comment #1) > Alternatively you could also warn only if there are no timecodes / fps==0/1, > and just write zero-timecodes. While this is not according to the spec, it > should work just fine in most software. Good idea. But, if there are already timecodes present, might these not follow the spec ? i.e. frame number between 1 and 60 ?
Timecodes for > 60 fps seem to be not very well-defined in general. What seems to happen most often is that they are just duplicated then (i.e. two consecutive frames have the same timecode). The GstVideoTimeCode API is not enforcing anything here (yet), but you should just assume for now that the values in there are valid.
(In reply to Sebastian Dröge (slomo) from comment #3) > Timecodes for > 60 fps seem to be not very well-defined in general. What > seems to happen most often is that they are just duplicated then (i.e. two > consecutive frames have the same timecode). > > The GstVideoTimeCode API is not enforcing anything here (yet), but you > should just assume for now that the values in there are valid. Thanks. Hope to get to this some time this week.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/587.