After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785202 - apps-menu: remove more dead code
apps-menu: remove more dead code
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.25.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-07-21 01:33 UTC by Alexander Rüedlinger (lexruee)
Modified: 2017-07-21 08:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch removes more dead code extensions/apps-menu/extension.js. (1.38 KB, patch)
2017-07-21 01:33 UTC, Alexander Rüedlinger (lexruee) 		committed Details | Review

Description Alexander Rüedlinger (lexruee) 2017-07-21 01:33:00 UTC 
Created attachment 356078 [details] [review]
This patch removes more dead code extensions/apps-menu/extension.js.

The submitted and accepted patch in report 785200 (https://bugzilla.gnome.org/show_bug.cgi?id=785200) removes dead code, namely a ::panel-box-changed signal handler.

Unfortunately, the patch in report 785200 forgot to remove the associated code in the method _onDestroy in the class ApplicationsButton, which removes the signal handler from the Main.layoutManager.
Comment 1 Florian Müllner 2017-07-21 08:12:28 UTC 
Gah, should have caught that in review - thanks again!