GNOME Bugzilla – Bug 785195
matroskamux: opus timestamps
Last modified: 2018-11-03 15:20:49 UTC
Created attachment 356070 [details] [review] tentative patch please try this pipeline: gst-launch-1.0 -v audiotestsrc ! opusenc ! matroskamux ! fakesink silent=false you have something like this: (16 bytes, dts: none, pts: 0:00:47.080000000 (3 bytes, dts: none, pts: 0:00:47.080000000 (19 bytes, dts: none, pts: 0:00:47.080000000 (160 bytes, dts: 0:00:47.073500000, pts: 0:00:47.073500000 with the attached patch ebml timestamp match buffer timestamp, I'm not 100% sure that this patch is correct
That probably makes sense to keep the PTS increasing but also not such much OTOH as the original timestamp is the actual timestamp for presentation (and the demuxer corrects for that again). I think the patch is fine as-is though. What problems does it cause for you specifically?
(In reply to Sebastian Dröge (slomo) from comment #1) > That probably makes sense to keep the PTS increasing but also not such much > OTOH as the original timestamp is the actual timestamp for presentation (and > the demuxer corrects for that again). I think the patch is fine as-is though. > good! > What problems does it cause for you specifically? I saw the correction in the demuxer so I was unsure if this is the right approach, in one of my GStreamer app I treat non monotonic timestamps as a special case so the actual behaviour for opus fill my logs with warnings ...
Hi Sebastian, based on your comments this patch seems good, if so can you please push to git master? Thanks
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/389.