GNOME Bugzilla – Bug 785137
"File conflict" dialog misses mnemonics, loses focus when tabbing through invisible fields
Last modified: 2017-08-17 13:57:01 UTC
* Copy some files from A to B. * Now copy again the same files from A to B. * Nautilus 3.24.1 shows a "File Conflict" dialog. * Realize that for unknown reasons, "> Select a new name for the destination" is highlighted. But pressing the Enter key triggers the "Replace" button instead. * Now press "Tab" one or two times. Where the hell are you? Tabbing obviously focuses the non-visible parts of the "new name" dropdown. This is superconfusing and it took me several tries to understand where my focus is, why "Apply this action to all files and folders" was suddenly disabled, and why the button in the top bar changed to "Rename" so I canceled and started copying from scratch again. Not very productive. Also there is neither a mnemonic for "Apply this action to all files and folders" nor a mnemonic for the "Replace" button. Together with the tab problem I had to switch to using a mouse.
Created attachment 356629 [details] [review] Proposed patch Hello, this is a proposed patch to solve the problem with the keyboard focus. I'll add a patch for the mnemonics in a minute. It may be a bit hacky but I couldn't think of a better solution. Oh and this was created as a part of the newcomer workshop at GUADEC 2017 and this is my first code for GNOME so it may not be up to the standards.
Created attachment 356634 [details] [review] Proposed patch 2 This patch adds a mnemonic (P) to the Replace button. Adding one to the Reset button breaks it (the underscore gets rendered instead of being handled as a mnemonic) and it's hard to choose a letter to be used as a shortcut.
Review of attachment 356634 [details] [review]: Looks good, thanks Martin!