GNOME Bugzilla – Bug 785083
Add vte_terminal_get_scroll_on functions
Last modified: 2017-09-13 19:28:54 UTC
I found that vte_terminal_get_scroll_on_{output,keystroke} functions are missing. The proposed patch adds them. Thanks.
Created attachment 355868 [details] [review] Add vte_terminal_get_scroll_on functions
Thanks... The methods should be added to doc/reference/vte-sections.txt too. While we're at it... there are a few more getters missing as seen from this file, e.g. get_size, get_color_blah, get_backspace/delete_binding etc... I was always wondering what's the point in getters where only the setter API can change the value. They're of course nice to have for completeness, but other than that, are they actually useful in practice?
Created attachment 355875 [details] [review] patch v2
Egmont, patch v2 adds them to vte-sections.txt, along with vte_terminal_{set,get}_input_enabled which are currently missing. As for why we need them - I've got a request to add a per-terminal setting for scrolling on output, and it would be very convenient to have a get function which would be used to show current terminal state.
Looks good, except it's missing the "Since: 0.50" annotations in the function's docs.
Created attachment 355883 [details] [review] patch v3
Christian, please see v3, thanks.
Committed. Do you want to do the same for the 'scrollback-lines' property too?
(In reply to Christian Persch from comment #8) > Committed. > > Do you want to do the same for the 'scrollback-lines' property too? Thanks! Yes, I will do that.