After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785083 - Add vte_terminal_get_scroll_on functions
Add vte_terminal_get_scroll_on functions
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other Windows
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-18 18:29 UTC by Igor
Modified: 2017-09-13 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add vte_terminal_get_scroll_on functions (2.56 KB, patch)
2017-07-18 18:31 UTC, Igor
none Details | Review
patch v2 (3.45 KB, patch)
2017-07-18 19:22 UTC, Igor
none Details | Review
patch v3 (3.49 KB, patch)
2017-07-18 20:10 UTC, Igor
accepted-commit_now Details | Review

Description Igor 2017-07-18 18:29:10 UTC
I found that vte_terminal_get_scroll_on_{output,keystroke} functions are missing. The proposed patch adds them. Thanks.
Comment 1 Igor 2017-07-18 18:31:03 UTC
Created attachment 355868 [details] [review]
Add vte_terminal_get_scroll_on functions
Comment 2 Egmont Koblinger 2017-07-18 19:13:10 UTC
Thanks...

The methods should be added to doc/reference/vte-sections.txt too.

While we're at it... there are a few more getters missing as seen from this file, e.g. get_size, get_color_blah, get_backspace/delete_binding etc...

I was always wondering what's the point in getters where only the setter API can change the value. They're of course nice to have for completeness, but other than that, are they actually useful in practice?
Comment 3 Igor 2017-07-18 19:22:34 UTC
Created attachment 355875 [details] [review]
patch v2
Comment 4 Igor 2017-07-18 19:26:19 UTC
Egmont, patch v2 adds them to vte-sections.txt, along with vte_terminal_{set,get}_input_enabled which are currently missing.

As for why we need them - I've got a request to add a per-terminal setting for scrolling on output, and it would be very convenient to have a get function which would be used to show current terminal state.
Comment 5 Christian Persch 2017-07-18 20:05:26 UTC
Looks good, except it's missing the "Since: 0.50" annotations in the function's docs.
Comment 6 Igor 2017-07-18 20:10:12 UTC
Created attachment 355883 [details] [review]
patch v3
Comment 7 Igor 2017-07-18 20:10:33 UTC
Christian, please see v3, thanks.
Comment 8 Christian Persch 2017-09-13 19:16:52 UTC
Committed.

Do you want to do the same for the 'scrollback-lines' property too?
Comment 9 Igor 2017-09-13 19:28:54 UTC
(In reply to Christian Persch from comment #8)
> Committed.
> 
> Do you want to do the same for the 'scrollback-lines' property too?
Thanks!
Yes, I will do that.