After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785078 - tests: Don't delete files after unpacking them
tests: Don't delete files after unpacking them
Status: RESOLVED FIXED
Product: gnome-autoar
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Autoar maintainer(s)
GNOME Autoar maintainer(s)
: 777392 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-07-18 16:18 UTC by Bastien Nocera
Modified: 2017-07-19 13:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Don't delete files after unpacking them (1.06 KB, patch)
2017-07-18 16:18 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-07-18 16:18:52 UTC 
.
Comment 1 Bastien Nocera 2017-07-18 16:18:55 UTC 
Created attachment 355859 [details] [review]
tests: Don't delete files after unpacking them

Test programs have no business doing this, and will likely delete files
that are necessary to debug gnome-autoar.
Comment 2 Carlos Soriano 2017-07-18 16:26:24 UTC 
Review of attachment 355859 [details] [review]:

LGTM, as you mentioned deleting files should be rather part of a unit test.
Comment 3 Ting-Wei Lan 2017-07-19 13:32:55 UTC 
Yes, this patch looks good. I don't know why the behavior of test-extract was changed when removing AutoarPref class ...
Comment 4 Ting-Wei Lan 2017-07-19 13:33:09 UTC 
*** Bug 777392 has been marked as a duplicate of this bug. ***
Comment 5 Bastien Nocera 2017-07-19 13:46:50 UTC 
Attachment 355859 [details] pushed as bb867a4 - tests: Don't delete files after unpacking them