GNOME Bugzilla – Bug 785033
Port to meson build system
Last modified: 2017-07-18 15:39:47 UTC
Let's join the party, shall we?
Created attachment 355771 [details] [review] Add meson build support While this patch adds support to build geocode-glib with meson build system, it doesn't remove the autotools support.
Created attachment 355772 [details] [review] Drop autotools support We can now build geocode-glib with meson.
Review of attachment 355771 [details] [review]: I've not tested the build. Comparing the installed files for both methods would also be good to do. ::: geocode-glib/geocode-glib.c @@ +28,3 @@ #include <langinfo.h> #include <geocode-glib/geocode-glib-private.h> +#include <config.h> If it needed to be included here, it would need to be near as the first include. Why is it needed here? ::: meson.build @@ +17,3 @@ +conf.set_quoted('PACKAGE_TARNAME', 'geocode-glib') +conf.set_quoted('PACKAGE_STRING', 'geocode-glib ' + gclib_version) +conf.set_quoted('PACKAGE_URL', 'https://wiki.gnome.org/Apps/Boxes') Nope. ::: meson_options.txt @@ +3,3 @@ + description: 'Build & install test programs') +option('disable-introspection', + type: 'boolean', value: false, This should probably be a tristate, true/false/auto, with auto the default. @@ +6,3 @@ + description: 'Whether to disable the introspection generation') +option('enable-gtk-doc', + type: 'boolean', value: false, I'd rather this was true by default.
Review of attachment 355771 [details] [review]: ::: geocode-glib/geocode-glib.c @@ +28,3 @@ #include <langinfo.h> #include <geocode-glib/geocode-glib-private.h> +#include <config.h> Because we no longer define PACKAGE_VERSION from CFLAGS. I think this is better way than doing that but if you disagree, I can go that way. ::: meson_options.txt @@ +3,3 @@ + description: 'Build & install test programs') +option('disable-introspection', + type: 'boolean', value: false, Don't see much point in that. If you don't disable gir through this option, it's the same as auto: meson only enables gir build if g-ir-scanner is available. I copied this from json-glib since i thought it makes more sense but again, if you still disagree, I'll change it.
Created attachment 355777 [details] [review] Add meson build support While this patch adds support to build geocode-glib with meson build system, it doesn't remove the autotools support.
Created attachment 355778 [details] [review] Drop autotools support We can now build geocode-glib with meson.
(In reply to Zeeshan Ali (Khattak) from comment #4) > Review of attachment 355771 [details] [review] [review]: > > ::: geocode-glib/geocode-glib.c > @@ +28,3 @@ > #include <langinfo.h> > #include <geocode-glib/geocode-glib-private.h> > +#include <config.h> > > Because we no longer define PACKAGE_VERSION from CFLAGS. I think this is > better way than doing that but if you disagree, I can go that way. Right, then this needs to be at the top of the includes, before any system includes as: #include "config.h" > ::: meson_options.txt > @@ +3,3 @@ > + description: 'Build & install test programs') > +option('disable-introspection', > + type: 'boolean', value: false, > > Don't see much point in that. If you don't disable gir through this option, > it's the same as auto: meson only enables gir build if g-ir-scanner is > available. Ha, double negative. > I copied this from json-glib since i thought it makes more sense > but again, if you still disagree, I'll change it.
(In reply to Bastien Nocera from comment #7) > (In reply to Zeeshan Ali (Khattak) from comment #4) > > Review of attachment 355771 [details] [review] [review] [review]: > > > > ::: meson_options.txt > > @@ +3,3 @@ > > + description: 'Build & install test programs') > > +option('disable-introspection', > > + type: 'boolean', value: false, > > > > Don't see much point in that. If you don't disable gir through this option, > > it's the same as auto: meson only enables gir build if g-ir-scanner is > > available. > > Ha, double negative. i-e you want me to change it?
Created attachment 355815 [details] [review] Add meson build support While this patch adds support to build geocode-glib with meson build system, it doesn't remove the autotools support.
Created attachment 355816 [details] [review] Drop autotools support We can now build geocode-glib with meson.
(In reply to Zeeshan Ali (Khattak) from comment #8) > (In reply to Bastien Nocera from comment #7) > > (In reply to Zeeshan Ali (Khattak) from comment #4) > > > Review of attachment 355771 [details] [review] [review] [review] [review]: > > > > > > ::: meson_options.txt > > > @@ +3,3 @@ > > > + description: 'Build & install test programs') > > > +option('disable-introspection', > > > + type: 'boolean', value: false, > > > > > > Don't see much point in that. If you don't disable gir through this option, > > > it's the same as auto: meson only enables gir build if g-ir-scanner is > > > available. > > > > Ha, double negative. > > i-e you want me to change it? No, enabled by default, but optional if absent is fine by me.
Created attachment 355822 [details] [review] Add meson build support While this patch adds support to build geocode-glib with meson build system, it doesn't remove the autotools support.
Created attachment 355823 [details] [review] Drop autotools support We can now build geocode-glib with meson.
Created attachment 355838 [details] [review] Add meson build support Fixed version in main meson.build
Created attachment 355839 [details] [review] Drop autotools support We can now build geocode-glib with meson.
Attachment 355838 [details] pushed as 2095bdc - Add meson build support Attachment 355839 [details] pushed as 3c74d75 - Drop autotools support
the meson build is installing /usr/lib/libgeocode-glib.so without /usr/lib/libgeocode-glib.so.0 Is that intentional?
(In reply to Hussam Al-Tayeb from comment #17) > the meson build is installing /usr/lib/libgeocode-glib.so without > /usr/lib/libgeocode-glib.so.0 > Is that intentional? I was missing the soversion in the library() call. I pushed the fix to git master now.