After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785027 - videorate: Outputs too much data on segment updates
videorate: Outputs too much data on segment updates
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 783842
 
 
Reported: 2017-07-17 14:57 UTC by Edward Hervey
Modified: 2018-11-03 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
check: Add test for videorate segment update handling (3.02 KB, patch)
2017-07-18 07:30 UTC, Edward Hervey
none Details | Review

Description Edward Hervey 2017-07-17 14:57:43 UTC
When an "update" segment arrives in videorate, the next timestamps is resetted, causing a huge amount of duplicate (and late) frames to be outputted.

To reproduce, using the gst-validate media suite:
gst-launch-1.0 -v uridecodebin uri=file://$HOME/gst-validate/gst-integration-testsuites/medias/defaults/mp4/fragmented_nonseekable_sink.mp4 ! identity name=before silent=False ! videorate ! fakesink name=after silent=False

What comes in to videorate:
* segment start:0, stop:2s
* buffers from 0 to 2s
* segment start:0, stop:4s
* buffers from 2s to 4s
* etc...

What comes out of videorate
* segment start:0 stop:2s
* buffers from 0 to 2s
* segment start:0, stop:4s
* buffers from 0 to 2s /!\
** The problem is right here. Those buffers are all duplicates of the incoming 2s buffer and are all late.
* buffers from 2s to 4s

Any element after videorate that assumes that timestamps are increasing is going to have a looot of problems.
Comment 1 Edward Hervey 2017-07-18 07:30:48 UTC
Created attachment 355801 [details] [review]
check: Add test for videorate segment update handling
Comment 2 GStreamer system administrator 2018-11-03 11:57:59 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/367.