After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785004 - [review] more NMDedupMulti changes (NMIP4Config, route delete) [th/dedup-multi-v2-bgo785004]
[review] more NMDedupMulti changes (NMIP4Config, route delete) [th/dedup-mult...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 784863 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-07-16 21:34 UTC by Thomas Haller
Modified: 2017-07-25 05:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2017-07-16 21:34:07 UTC 
- refactor NMIP4Config and NMIP6Config's handling of addresses to use NMDedupMultiIndex

- refactor all uses of nm_platform_ip._address_get_all(), to avoid a full clone of the address list


Please review
Comment 1 Thomas Haller 2017-07-16 21:35:38 UTC 
ah, and fix deleting routes with TOS != 0.
Comment 2 Beniamino Galvani 2017-07-21 07:42:07 UTC 
Pushed some fixups
Comment 3 Beniamino Galvani 2017-07-21 07:44:33 UTC 
*** Bug 784863 has been marked as a duplicate of this bug. ***
Comment 4 Beniamino Galvani 2017-07-21 07:46:11 UTC 
The branch also fixes a 'make check' failure on 1.8. Let's remember to backport the relevant commits when the branch is merged (see bug 784863).