GNOME Bugzilla – Bug 784998
Favorites are only added to playlist after restart
Last modified: 2018-01-08 12:13:28 UTC
Steps to reproduce: 1. Mark a song as favorite. 2. Select the playlist tab and favorites. Result: The favorite song wasn't be added. Workaround: Restart gnome-music. Now the song is been added to the playlist.
Yeah this is a known issue with the playlist view not being updated/triggered since we redid some internals and made it mostly async. The current playlist code is not up to standards, but it is what we have to work with for now. We need to figure out where in the chain it fails, someone investigating this would be awesome.
Created attachment 362933 [details] mp3 with embedded cover Level 7 by Monplaisir http://freemusicarchive.org/music/Monplaisir/Ride_Out_OST/Monplaisir_-_Ride_Out_OST_-_07_Level_7 https://chezmonplaisir.bandcamp.com/album/ride-out-ost http://creativecommons.org/licenses/by/3.0/
Created attachment 363294 [details] [review] disclistboxwidget: update favorite playlist When marking a song as favorite, update Static Favorites Playlist
Review of attachment 363294 [details] [review]: lgtm
Review of attachment 363294 [details] [review]: Ok was waiting to test it, but it works fine. ::: gnomemusic/widgets/disclistboxwidget.py @@ +32,3 @@ import gnomemusic.utils as utils +playlists = Playlists.get_default() this can be moved inside the class @@ +373,3 @@ favorite = song_widget.star_image.get_favorite() grilo.set_favorite(self._model[song_widget.itr][5], favorite) + playlists.update_static_playlist(StaticPlaylists.Favorites) The FIXME a few lines above also applies to this, but it will do for now.
Created attachment 365466 [details] [review] disclistboxwidget: update favorite playlist When marking a song as favorite, update Static Favorites Playlist
Review of attachment 365466 [details] [review]: lgtm
Merged in https://gitlab.gnome.org/GNOME/gnome-music/merge_requests/23 . Adding it to 3.26 too. Thanks for the patch.