GNOME Bugzilla – Bug 784988
openh264enc: allow to dynamically change bitrate
Last modified: 2017-07-17 23:17:55 UTC
Created attachment 355694 [details] [review] proposed patch .
Created attachment 355695 [details] simple application to test the patch
Comment on attachment 355694 [details] [review] proposed patch Looks good but can you do that in two patches, one only changing the indentation and the other doing the actual change?
Also GST_PARAM_MUTABLE_PLAYING is set but not checked anywhere (either check for it or remove it). And since you're at it it would be great if you did the same for max-bitrate so people don't trip when they realize one can be changed but not the other.
(In reply to Alessandro Decina from comment #3) > Also GST_PARAM_MUTABLE_PLAYING is set but not checked anywhere (either check > for it or remove it). I think GST_PARAM_MUTABLE_PLAYING is mostly for documentation, and this one means we can do it in any mode, so no need to check. > And since you're at it it would be great if you did > the same for max-bitrate so people don't trip when they realize one can be > changed but not the other. No flags means it can only be changed in NULL even though that's horribly documented.
Created attachment 355789 [details] [review] indentation fix
Created attachment 355790 [details] [review] allow to dynamically change bitrate/max bitrate
Created attachment 355791 [details] [review] add GST_PARAM_MUTABLE_PLAYING I think it is useful to see that the property can be changed in any state using gst-inspect, anyway I did a separate patch so you cannot push this one if you don't like it
merged commit e8f11615bd2ceede201398fd3b409dacadc4de5c (HEAD -> master, upstream/master) Author: Nicola Murino <nicola.murino@gmail.com> Date: Tue Jul 18 00:52:03 2017 +0200 openh264enc: set GST_PARAM_MUTABLE_PLAYING for bitrate/max-bitrate properties This way is documented that these properties can be changed in any state https://bugzilla.gnome.org/show_bug.cgi?id=784988 commit 11e8cf92f27188cdda2c6690f7130106e90f21d8 Author: Nicola Murino <nicola.murino@gmail.com> Date: Tue Jul 18 00:49:12 2017 +0200 openh264enc: allow to dynamically change bitrate https://bugzilla.gnome.org/show_bug.cgi?id=784988 commit 20b5db0615caa3a21fd0bf0727b22d7246bb6699 Author: Nicola Murino <nicola.murino@gmail.com> Date: Tue Jul 18 00:36:27 2017 +0200 openh264enc: fix indentation https://bugzilla.gnome.org/show_bug.cgi?id=784988