After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784975 - Port to meson build system
Port to meson build system
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
3.25.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on: 784974
Blocks: 782980
 
 
Reported: 2017-07-15 09:11 UTC by Iñigo Martínez
Modified: 2017-07-17 14:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Port to meson build system (16.20 KB, patch)
2017-07-15 09:11 UTC, Iñigo Martínez
none Details | Review
Remove autotools (46.42 KB, patch)
2017-07-16 10:25 UTC, Iñigo Martínez
committed Details | Review
Port to meson build system (16.20 KB, patch)
2017-07-16 11:21 UTC, Iñigo Martínez
committed Details | Review

Description Iñigo Martínez 2017-07-15 09:11:06 UTC
Created attachment 355670 [details] [review]
Port to meson build system

Complete port to meson build system.
Comment 1 Iñigo Martínez 2017-07-15 09:17:29 UTC
I have also created a branch[0] to ease its testing.

Any suggestion is very appreciated.

[0] https://git.gnome.org/browse/gnome-disk-utility/log/?h=wip/inigomartinez/meson
Comment 2 Kai Lüke 2017-07-15 12:17:28 UTC
Hello,

wow, that's neat, so we can get meson support this cycle, that you so much!
I can't tell how this should be tested, in a quick try all was fine - but the idea would be to ship both build systems for some time? If that's the case there is not much against putting it on master.
Maybe someone experienced with meson can also acknowledge the patch.

How does the release process differ? Should I stick to autotools in order to have the ./configure in the tar archive or is it ok ship the result of ninja dist?

Regards,
Kai
Comment 3 Iñigo Martínez 2017-07-15 14:58:11 UTC
I don't know what is exactly the plan. I think that, at least, to have meson available as build system. There are some applications (totem is the one I worked on) that have removed autotools to avoid maintaining two build systems.

Regarding release process, I have never done any, so I don't know. I can say that, from meson 0.41, dist command is available (ninja build dist), which may help on the release process.
Comment 4 Kai Lüke 2017-07-15 16:58:08 UTC
Of course I am tempted to drop it but since Debian stretch only has an older meson, this excludes from contributing via simple clone and build with system libraries/tooling.

At least until we figure out how the flatpak process could work in combinaiton with a system UDisks (the UDisks client library and D-Bus service versions do not match).
Comment 5 Iñigo Martínez 2017-07-16 10:25:37 UTC
Created attachment 355700 [details] [review]
Remove autotools

As a follow up on the meson build path, this patch removes autotool as build system, just in case it is considered.
Comment 6 Iñigo Martínez 2017-07-16 11:21:39 UTC
Created attachment 355703 [details] [review]
Port to meson build system

Minor improvement regarding meson build port patch, which changes the way scalable images are installed. Now the two SVG files are listed, and their existence checked, along their relative path instead of building their path when iterating through them.
Comment 7 Kai Lüke 2017-07-17 14:55:11 UTC
Thanks a lot for working on this, the switch with droping autotools is now done.