After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784957 - build failure with gcc 7.1.1
build failure with gcc 7.1.1
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-14 15:49 UTC by Hussam Al-Tayeb
Modified: 2017-07-15 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove extra 'const' (1.22 KB, patch)
2017-07-14 15:49 UTC, Hussam Al-Tayeb 		none Details | Review
more likely patch (1.25 KB, patch)
2017-07-15 11:28 UTC, Jonathan Matthew 		committed Details | Review

Description Hussam Al-Tayeb 2017-07-14 15:49:19 UTC 
Created attachment 355614 [details] [review]
Remove extra 'const'

gcc 7.1.1 complains about duplicate ‘const’ declaration specifier.
Comment 1 Jonathan Matthew 2017-07-15 10:55:09 UTC 
This doesn't look at all right to me.  What specifically does the compiler complain about?
Comment 2 Hussam Al-Tayeb 2017-07-15 11:17:51 UTC 
  CC       rb-text-helpers.lo
rb-text-helpers.c:52:19: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier]
 static const char const *UNICODE_LRM = "\xE2\x80\x8E";
                   ^~~~~
rb-text-helpers.c:53:19: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier]
 static const char const *UNICODE_RLM = "\xE2\x80\x8F";
                   ^~~~~
rb-text-helpers.c:54:19: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier]
 static const char const *UNICODE_LRE = "\xE2\x80\xAA";
                   ^~~~~
rb-text-helpers.c:55:19: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier]
 static const char const *UNICODE_RLE = "\xE2\x80\xAB";
                   ^~~~~
rb-text-helpers.c:56:19: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier]
 static const char const *UNICODE_PDF = "\xE2\x80\xAC";
                   ^~~~~
Comment 3 Jonathan Matthew 2017-07-15 11:28:00 UTC 
Created attachment 355677 [details] [review]
more likely patch

this is what the code was intending to do
Comment 4 Hussam Al-Tayeb 2017-07-15 11:30:17 UTC 
(In reply to Jonathan Matthew from comment #3)
> Created attachment 355677 [details] [review] [review]
> more likely patch
> 
> this is what the code was intending to do

Thanks. it compiles correctly now.
Comment 5 Jonathan Matthew 2017-07-15 12:47:31 UTC 
Review of attachment 355677 [details] [review]:

pushed as commit 40753f9
Comment 6 Hussam Al-Tayeb 2017-07-15 13:31:22 UTC 
Thank you for looking into this and for the fix.