After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784940 - build: Fix tracker detection
build: Fix tracker detection
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-14 09:35 UTC by Bastien Nocera
Modified: 2017-07-18 01:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix tracker detection (2.34 KB, patch)
2017-07-14 09:35 UTC, Bastien Nocera 		committed Details | Review
build: Make tracker a hard dependency (10.86 KB, patch)
2017-07-18 01:20 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-07-14 09:35:35 UTC 
This change should also be made for other options, we expect most of those
options to be automatically detected, unless the options are forcefully
passed.
Comment 1 Bastien Nocera 2017-07-14 09:35:53 UTC 
Created attachment 355575 [details] [review]
build: Fix tracker detection

Make sure that tracker-sparql is optional and auto-detected by default
and that tracker-sparql-1.0 is still supported.
Comment 2 Carlos Soriano 2017-07-17 09:41:44 UTC 
Review of attachment 355575 [details] [review]:

Actually we wanted to change this to require tracker as hard dep, no optional, since we accumulated too many features relying on tracker and more are coming (nautilus currently fails to build withouth tracker actually due to latest changes iirc).

Wanna change the patch to reflect that?

And thanks for taking the time Bastien!
Comment 3 Bastien Nocera 2017-07-18 01:20:56 UTC 
Created attachment 355796 [details] [review]
build: Make tracker a hard dependency

A large number of core features require Tracker to work, and many of the
new features using Tracker don't have any fallback support, failing to
build when Tracker is not available, so make tracker a hard requirement.
Comment 4 Bastien Nocera 2017-07-18 01:25:46 UTC 
Attachment 355575 [details] pushed as 4ac20d7 - build: Fix tracker detection
Attachment 355796 [details] pushed as e367134 - build: Make tracker a hard dependency