Created attachment 355564 [details] [review]
[PATCH] basesink: fix buffer leaks if preroll failed

In gst_base_sink_chain_unlocked, it is supposed to unref the obj when it's done.
When 'gst_base_sink_do_preroll' returns error and goes to 'preroll_failed', the object is not unreferenced.

Problem:
video freeze after "pause -> 1/2 FF -> resume -> pause -> 1/2 FF ..." repeatedly

--- a/libs/gst/base/gstbasesink.c
+++ b/libs/gst/base/gstbasesink.c
@@ -3657,6 +3657,7 @@ dropped:
 preroll_failed:
   {
     GST_DEBUG_OBJECT (basesink, "preroll failed: %s", gst_flow_get_name (ret));
+    gst_mini_object_unref (GST_MINI_OBJECT_CAST (obj));
     return ret;
   }
 }