GNOME Bugzilla – Bug 784914
Mark classes not derived from as final
Last modified: 2017-07-23 17:45:35 UTC
Created attachment 355529 [details] [review] [RFC PATCH] libview: Make class EvDocumentModel final As I mentioned in this thread [0], I'm trying to learn about GObject and Evince. As I read GObject's documentation and Evince's code I sometimes find what to my beginner eyes seem like disagreements or discrepancies. This report/RFC is an attempt at understanding (and perhaps fix) one such disagreement. 0: https://mail.gnome.org/archives/evince-list/2017-July/msg00000.html The attached patch is an initial test applied to a single class to serve as RFC. If deemed appropriate then analogous changes should be applied to other classes. Thanks.
Review of attachment 355529 [details] [review]: Looks fine to me.
Comment on attachment 355529 [details] [review] [RFC PATCH] libview: Make class EvDocumentModel final Pushed to git master, thanks.
I didn't close this because the title says "classes" but the committed patch only does it for one, so I assumed more patches will be submitted. Anyway, feel free to reopen if you wans to attach more patches here.
comment #3: > I didn't close this because the title says "classes" but the committed > patch only does it for one, so I assumed more patches will be > submitted. Yes that's what I had in mind. Seems like there are many places where similar changes could be made. > Anyway, feel free to reopen if you wans to attach more > patches here.