GNOME Bugzilla – Bug 784913
[PATCH] libgd: Update from libgd git master (bonus: fixes compilation warning)
Last modified: 2017-07-22 12:41:51 UTC
Created attachment 355526 [details] [review] libgd: Fix compilation warning Remove declaration for unused variable. Since I was in the area, this patch also changes a hardcoded integer into a more descriptive macro.
Review of attachment 355526 [details] [review]: libgd is a separate library, from which we copied a number of files. I'll be attaching a patch to update all those files to more recent versions. Let me know whether the warning still happens with that patch, and we'll fix it in libgd itself.
Created attachment 355961 [details] [review] libgd: Update from libgd git master
Created attachment 355988 [details] [review] libgd: Update from libgd git master
(In reply to Bastien Nocera from comment #3) > Created attachment 355988 [details] [review] [review] > libgd: Update from libgd git master Needed to change gd_embed_surface_in_frame() from gd_embed_image_in_frame()
Review of attachment 355988 [details] [review]: Did a trial build and nothing broke :D. Warning is gone too. I changed the report title according to the new scope. About the additional change in my original patch, I opened a new report for libgd specifically: https://bugzilla.gnome.org/show_bug.cgi?id=785159 You might want to apply that to libgd first (if deemed OK), then refresh this patch.
Created attachment 356005 [details] [review] libgd: Update from libgd git master
Attachment 356005 [details] pushed as 5bc3704 - libgd: Update from libgd git master