After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784913 - [PATCH] libgd: Update from libgd git master (bonus: fixes compilation warning)
[PATCH] libgd: Update from libgd git master (bonus: fixes compilation warning)
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-13 15:20 UTC by astian
Modified: 2017-07-22 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libgd: Fix compilation warning (1.42 KB, patch)
2017-07-13 15:20 UTC, astian
rejected Details | Review
libgd: Update from libgd git master (18.22 KB, patch)
2017-07-19 16:09 UTC, Bastien Nocera
none Details | Review
libgd: Update from libgd git master (19.08 KB, patch)
2017-07-20 00:19 UTC, Bastien Nocera
none Details | Review
libgd: Update from libgd git master (19.32 KB, patch)
2017-07-20 04:48 UTC, Bastien Nocera
committed Details | Review

Description astian 2017-07-13 15:20:01 UTC
Created attachment 355526 [details] [review]
libgd: Fix compilation warning

Remove declaration for unused variable.

Since I was in the area, this patch also changes a hardcoded integer
into a more descriptive macro.
Comment 1 Bastien Nocera 2017-07-19 16:09:43 UTC
Review of attachment 355526 [details] [review]:

libgd is a separate library, from which we copied a number of files. I'll be attaching a patch to update all those files to more recent versions.
Let me know whether the warning still happens with that patch, and we'll fix it in libgd itself.
Comment 2 Bastien Nocera 2017-07-19 16:09:59 UTC
Created attachment 355961 [details] [review]
libgd: Update from libgd git master
Comment 3 Bastien Nocera 2017-07-20 00:19:25 UTC
Created attachment 355988 [details] [review]
libgd: Update from libgd git master
Comment 4 Bastien Nocera 2017-07-20 00:24:15 UTC
(In reply to Bastien Nocera from comment #3)
> Created attachment 355988 [details] [review] [review]
> libgd: Update from libgd git master

Needed to change gd_embed_surface_in_frame() from gd_embed_image_in_frame()
Comment 5 astian 2017-07-20 03:47:35 UTC
Review of attachment 355988 [details] [review]:

Did a trial build and nothing broke :D.  Warning is gone too.

I changed the report title according to the new scope.

About the additional change in my original patch, I opened a new report for libgd specifically:
https://bugzilla.gnome.org/show_bug.cgi?id=785159

You might want to apply that to libgd first (if deemed OK), then refresh this patch.
Comment 6 Bastien Nocera 2017-07-20 04:48:55 UTC
Created attachment 356005 [details] [review]
libgd: Update from libgd git master
Comment 7 Bastien Nocera 2017-07-22 12:41:46 UTC
Attachment 356005 [details] pushed as 5bc3704 - libgd: Update from libgd git master