GNOME Bugzilla – Bug 784910
Port to meson build system
Last modified: 2017-10-22 20:25:42 UTC
Created attachment 355520 [details] [review] abicheck script update to get library from different place Port to meson build system. It also includes a minor patch for abicheck script so it can work with 'dconfsetting' library located in a different place, that is necessary for meson which build all the objects in a different location. Some further improvements are also possible.
Created attachment 355521 [details] [review] Port to meson build system
Created attachment 357095 [details] [review] Port to meson build system An update to meson build port patch which includes meson build files to autotools as extra files so they are also included in the distributable package. It also removes C99 as the default standard, so compiler's default standard will be used. Some aesthetic changes have also been made to improve readibility.
Created attachment 357096 [details] [review] Remove autotools Some applications are removing autotools as build system to avoid the burden of maintaining two build systems. Just in case this is considered, this patch removes autotools as build system.
Note: I'll be doing a dconf release on behalf of release team with these patches if there's no response from maintainers here after a few days.
Created attachment 360604 [details] [review] Changed abicheck.sh script The commit message has been updated and also the bug URI has been included.
Created attachment 360605 [details] [review] Port to meson build system Revised patch with some minor improvements and license fix. The license has been changed from `LGPL2.1` to `LGPL2.1+`.
Created attachment 360606 [details] [review] Remove autotools Proper commit message has been included an also the bug URI has been included.
(In reply to Michael Catanzaro from comment #4) > Note: I'll be doing a dconf release on behalf of release team with these > patches if there's no response from maintainers here after a few days. Done. Thanks again Iñigo!
Created attachment 361920 [details] [review] Update the README file The following comment[0] has pointed out that I've forgotten to update the README file, with proper steps to build dconf with meson. This patch replaces the autotools commands with their meson equivalents. I've also removed any mention of dconf-editor, which is not part of dconf anymore. [0] https://www.phoronix.com/forums/forum/phoronix/latest-phoronix-articles/984036-libinput-1-9-released-with-input-improvements-requires-meson?p=984064#post984064
Review of attachment 361920 [details] [review]: One more thing I notice is that we forgot to remove the .gitignores, which are no longer needed now that builds are out-of-tree. Except the toplevel directory should perhaps have a .gitignore that just ignores build/ since that's a pretty common place to create the builddir. ::: README @@ +63,3 @@ applications). +bin/ is written in Vala. The Vala compiler is not required to compile What, is this really true, meson is including generated C sources in the dist tarball? A horrible mistake if true, but checking the tarball I see that's not the case. So the Vala compiler really is needed now.
Created attachment 362031 [details] [review] Update the README file Fixed!
Created attachment 362033 [details] [review] Remove .gitignore files (In reply to Michael Catanzaro from comment #10) > Review of attachment 361920 [details] [review] [review]: > > One more thing I notice is that we forgot to remove the .gitignores, which > are no longer needed now that builds are out-of-tree. Except the toplevel > directory should perhaps have a .gitignore that just ignores build/ since > that's a pretty common place to create the builddir. I've just removed all the .gitignore files. IMO, there is no much problem of seeing the `builddir` in the git status so you can be aware of how many `builddir` are present (probably only one called *build*).
Comment on attachment 362031 [details] [review] Update the README file Pushed as a4e1149 - Update the README file
Comment on attachment 362033 [details] [review] Remove .gitignore files Pushed as f82500d - Remove .gitignore files