GNOME Bugzilla – Bug 784906
Add the Shift + Ctrl + T and the Ctrl + T shortcuts in Help
Last modified: 2017-10-21 18:58:16 UTC
Mention CTRL+SHIFT+T on http://help.gnome.org/users/epiphany/stable/keyboard-shortcut.html.en
Created attachment 355719 [details] [review] Added the Shift + Ctrl + T and the Ctrl + T shortcuts I fixed it and also added the open new tab shortcut, would you mind changing the title to accommodate that?
Dan: Do not close bugs that are not fixed. Thanks.
OK, thanks. Docs team likes to review documentation patches, so I'll leave this for them. In my experience they usually go through patches in batches once or twice a year, so don't be discouraged if it takes a while.
(In reply to Michael Catanzaro from comment #3) > OK, thanks. Docs team likes to review documentation patches, so I'll leave > this for them. In my experience they usually go through patches in batches > once or twice a year, so don't be discouraged if it takes a while. Wow, can't believe I wrote this. I was trying way too hard to avoid reviewing such a simple patch. Let's just land it.
(In reply to Michael Catanzaro from comment #3) > OK, thanks. Docs team likes to review documentation patches That's actually true, by the way, but doesn't mean we should let it delay us.
Review of attachment 355719 [details] [review]: OK, I tried building with this patch but I see a huge amount of errors. Did you test it? Running custom install script '/usr/bin/python3 /home/mcatanzaro/Projects/GNOME/install/bin/meson --internal yelphelper install --subdir=help --id=epiphany --installdir=share/help --sources=index.page@@introduction.page@@legal.xml@@browse-local.page@@browse-private.page@@browse-tab.page@@browse-web.page@@browse-webapps.page@@browse-webapps-del.page@@cert.page@@cookies.xml@@data-cookies.page@@data-passwords.page@@history.page@@history-delete.page@@keyboard-shortcut.page@@pref.page@@pref-cookies.page@@pref-css.page@@pref-downloads.page@@pref-do-not-track.page@@pref-font.page@@pref-passwords.page@@prob-restore-closed-page.page@@proxy.page --media=media/epiphany-3-12.png@@media/private-browsing-3-12.png@@media/web-browser.png --langs=cs@@de@@el@@es@@fr@@hu@@ko@@pl@@pt_BR@@ru@@sv' Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^ Error: Could not parse document: /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: Shift line 112 and key <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : expected '>' <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:112: parser error : Opening and ending tag mismatch: keyseq line 112 and p <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:113: parser error : Opening and ending tag mismatch: p line 112 and td </td> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:114: parser error : Opening and ending tag mismatch: td line 111 and tr </tr> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:373: parser error : Opening and ending tag mismatch: tr line 107 and tbody </tbody> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:374: parser error : Opening and ending tag mismatch: tbody line 42 and table </table> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:375: parser error : Opening and ending tag mismatch: table line 31 and page </page> ^ /home/mcatanzaro/Projects/GNOME/epiphany/help/C/keyboard-shortcut.page:376: parser error : Premature end of data in tag page line 1 ^
Review of attachment 355719 [details] [review]: ::: help/C/keyboard-shortcut.page @@ +110,3 @@ + </td> + <td> + <p><keyseq><key><Shift></key><key>Ctrl</key><key>T</key></keyseq></p> The problem is the <brackets> around Shift. You've inadvertently created an XML tag. :)
Created attachment 356622 [details] [review] Fixes the Added the Shift + Ctrl + T and the Ctrl + T shortcuts fix to the previous attachment Sorry, none of my machines have the dependencies to pass configure and I don't have the patience to investigate how to fix jhbuild. I would have tested if I did have the required dependencies though. Thanks for testing.
Review of attachment 356622 [details] [review]: You don't have to build (when not adding new pages / files). You could open the page locally in yelp and watch the output on the terminal / console, via "yelp ./help/C/keyboard-shortcut.page". The patch looks good to me.
(In reply to André Klapper from comment #9) > You could open the page locally in yelp and watch the output on the terminal > / console, via "yelp ./help/C/keyboard-shortcut.page". Thanks for the information, this is very handy.
OK, thanks for your contribution!
OK, thanks for your contribution! This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
This was pushed back in July.