GNOME Bugzilla – Bug 784891
[PATCH] g_array_append_val() in get_system_session_dirs() never works
Last modified: 2017-07-17 13:56:59 UTC
In https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1704050 we found that using the g_array_append_val() code path in get_system_session_dirs() does not work. This is because g_array_append_val is appending after a NULL (there are two of them) and so g_strdupv never finds the wayland_search_dir entry.
Patch coming in a minute...
Created attachment 355485 [details] [review] First attempt at a fix
Review of attachment 355485 [details] [review]: Looks right, but note this bug will only manifest if you're building with --disable-user-display-server and --enable-wayland-support. is that the configuration you want, it's a little unusual?
In Ubuntu we have distro-patched a similar change that calls g_array_append_val unconditionally. So it's rather important to Ubuntu right now.
Thanks pushed, with a different commit message as commit d81a471.