Created attachment 355481 [details] [review]
gtkapplication: Mark gtk_application_get_active_window() as nullable

Review of attachment 355481 [details] [review]:

This should be pushed in master and gtk-3-22 once it's accepted, I presume?

::: gtk/gtkapplication.c
@@ +861,3 @@
  * recently-focused window within this application.
  *
+ * Returns: (transfer none) (nullable): the active window

We usually also explain when/why the function may return NULL like in https://git.gnome.org/browse/gtk+/tree/gtk/gtkwindow.c#n2789

Created attachment 355546 [details] [review]
gtkapplication: Mark gtk_application_get_active_window() as nullable

(In reply to Timm Bäder from comment #2)
> Review of attachment 355481 [details] [review] [review]:
> 
> This should be pushed in master and gtk-3-22 once it's accepted, I presume?

The fix is valid in 3.22 as well, so presumably yes.

> ::: gtk/gtkapplication.c
> @@ +861,3 @@
>   * recently-focused window within this application.
>   *
> + * Returns: (transfer none) (nullable): the active window
> 
> We usually also explain when/why the function may return NULL like in
> https://git.gnome.org/browse/gtk+/tree/gtk/gtkwindow.c#n2789

Makes sense, updated with that.

Review of attachment 355546 [details] [review]:

looks fine to me

Thanks for the reviews. Just as an FYI, I don't have seem to have git access to GNOME repos any more, so someone will need to push these out for me.

Attachment 355546 [details] pushed as 4b1853b - gtkapplication: Mark gtk_application_get_active_window() as nullable