After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784852 - gimpcellrenderertoggle: Simplify build
gimpcellrenderertoggle: Simplify build
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-12 14:20 UTC by Bastien Nocera
Modified: 2017-07-12 16:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gimpcellrenderertoggle: Simplify build (4.30 KB, patch)
2017-07-12 14:20 UTC, Bastien Nocera 		committed Details | Review
build: Remove all mentions of old generated files (1.12 KB, patch)
2017-07-12 16:30 UTC, Emmanuele Bassi (:ebassi) 		accepted-commit_now Details | Review

Description Bastien Nocera 2017-07-12 14:20:30 UTC 
.
Comment 1 Bastien Nocera 2017-07-12 14:20:34 UTC 
Created attachment 355434 [details] [review]
gimpcellrenderertoggle: Simplify build

By removing glib-genmarshal usage, seeing as the generic marshaller via
libffi works just as well.
Comment 2 Michael Catanzaro 2017-07-12 14:28:23 UTC 
Review of attachment 355434 [details] [review]:

::: cut-n-paste/gimpcellrenderertoggle/gimpcellrenderertoggle.c
@@ +96,3 @@
                   G_STRUCT_OFFSET (GimpCellRendererToggleClass, clicked),
                   NULL, NULL,
+                  g_cclosure_marshal_generic,

I prefer to just write NULL instead. But Carlos likes writing out g_cclosure_marshal_generic for some reason, so he will probably appreciate this. :D
Comment 3 Bastien Nocera 2017-07-12 14:53:05 UTC 
Attachment 355434 [details] pushed as 827f151 - gimpcellrenderertoggle: Simplify build
Comment 4 Emmanuele Bassi (:ebassi) 2017-07-12 16:30:04 UTC 
Created attachment 355444 [details] [review]
build: Remove all mentions of old generated files

We don't build marshallers any more, so we must not reference them in
the list of sources.
Comment 5 Bastien Nocera 2017-07-12 16:31:29 UTC 
Review of attachment 355444 [details] [review]:

Obviously...