After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784830 - How to handle empty "Volume is busy" dialog better?
How to handle empty "Volume is busy" dialog better?
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-07-12 05:14 UTC by Robert Orzanna
Modified: 2017-07-14 10:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
"Volume is busy" dialog screenshot (11.43 KB, image/png)
2017-07-12 05:14 UTC, Robert Orzanna
Details

Description Robert Orzanna 2017-07-12 05:14:58 UTC
Created attachment 355382 [details]
"Volume is busy" dialog screenshot

I want to discuss how to improve the user experience of the "Volume is busy" dialog window. 

Sometimes it happens to me that I want to unmount my external USB drive and then get to see this "Volume is busy" dialog window. However, it's empty meaning I cannot identify easily which application or process keeps the volume busy. 

Thus, an empty "Volume is busy" dialog window is of absolutely no use and help here. 

Please see the attached screenshot for an example.
Comment 1 Carlos Soriano 2017-07-12 17:59:12 UTC
Indeed, this need better UI (although that custom theme you are using makes it worse imho).
Comment 2 Robert Orzanna 2017-07-13 04:35:58 UTC
Carlos, just to be clear: this is not a custom theme but the default theme that Solus Budgie comes with. Thus this is not the experience of a "hacker" using his own modified theme but a new user installing a distro that comes with Nautilus to see this default experience.
Comment 3 Carlos Soriano 2017-07-13 12:57:59 UTC
(In reply to Robert Orzanna from comment #2)
> Carlos, just to be clear: this is not a custom theme but the default theme
> that Solus Budgie comes with. Thus this is not the experience of a "hacker"
> using his own modified theme but a new user installing a distro that comes
> with Nautilus to see this default experience.

I understand.

However we don't support neither recommend any other theme than Adwaita which is the theme we do, test and design against, and that one is not Adwaita :)

I understand Solus use a different one, but that's something you would need to discuss with them. Note that this doesn't change the fact that that dialog needs work on our side, just that a different theme than Adwaita makes it worse imho.
Comment 4 Robert Orzanna 2017-07-13 13:02:39 UTC
I agree, Carlos.

Let's improve your side first and then I am taking back whatever else is missing or needed to Solus.
Comment 5 Ondrej Holy 2017-07-14 07:47:27 UTC
One thing is the appearance of the dialog, another thing is a question, why it is empty. GVfs udisks2 volume monitor should return a list of pids from "lsof" command to the client if umount failed with UDISKS_ERROR_DEVICE_BUSY. The client side should resolve application names and list them in the dialog. Is the dialog always empty for you? Can you please try to run "lsof -t [mountpoint]" manually in such case to see if it contains something, or not? We have to find in what cases may be empty and show some reasonable error messages instead of the empty list...
Comment 6 Robert Orzanna 2017-07-14 08:07:44 UTC
"lsof" is not preinstalled by default on Solus. Can this dialog work at all without lsof? If not, Solus needs to add lsof as a dependency for Nautilus, I guess.

> orschiro@x230 ~ $ lsof
> bash: lsof: command not found
Comment 7 Ondrej Holy 2017-07-14 09:01:25 UTC
Ah, that's the issue, the output will be always empty and you should see "Error launching lsof(1)" in logs. GVfs (not Nautilus) needs lsof dependency to see blocking processes... and then you should not see the empty dialog in majority cases.
Comment 8 Robert Orzanna 2017-07-14 09:24:08 UTC
Let me report this to Solus and try to get their response!
Comment 9 Robert Orzanna 2017-07-14 09:27:32 UTC
For further reference: https://dev.solus-project.com/T4076
Comment 10 Joshua Strobl 2017-07-14 09:40:38 UTC
Thanks Carlos and Ondrej on the quick response. Resolving downstream right now.
Comment 11 Joshua Strobl 2017-07-14 09:48:43 UTC
Resolved downstream. Added rundep to gvfs.
Comment 12 Ernestas Kulik 2017-07-14 10:14:31 UTC
(In reply to Joshua Strobl from comment #11)
> Resolved downstream. Added rundep to gvfs.

Thanks!