Bug 784773 - Add support for installing classic confinement snaps.
Add support for installing classic confinement snaps.
Status: NEW
Product: gnome-software
Classification: Applications
Component: Snap
git master
Other Linux
: Normal normal
: ---
Assigned To: Robert Ancell
Robert Ancell
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2017-07-11 03:41 UTC by James Henstridge
Modified: 2017-12-13 22:06 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-snap-Install-classic-snaps.patch (2.47 KB, patch)
2017-07-11 03:41 UTC, James Henstridge
committed Details | Diff | Review
0002-Display-a-warning-for-non-sandboxed-snap-packages.patch (5.75 KB, patch)
2017-07-11 03:42 UTC, James Henstridge
none Details | Diff | Review

Description James Henstridge 2017-07-11 03:41:08 UTC
At the moment, if the user attempts to install a snap that requires classic confinement, the install fails.

For the command line UI, the user has to pass the extra "--classic" argument to install such snaps, which is converted to a flag on the install API call.  This is intended to get the user to acknowledge that they are installing third party software that is not sandboxed from the rest of the system.

The first patch is an updated version of Robert's that simply allows installing of classic confinement snaps, which I think is appropriate for upstream use.

The second patch adds a warning to the package details page when displaying such snaps, which might be an Ubuntu only change.  I realise that this doubles up with the existing "Sandboxed" kudo badge, but I do think we need a bit more than just that badge.  At present, there are two reasons why that badge might not display on a package on Ubuntu:

1. we're showing a .deb package from the Ubuntu archive, managed by a trusted set of developers.

2. we're showing a .snap package from a third party developer that requires classic confinement.

(1) is going to be the most common case, and is generally not a problem, so I suspect few users will appreciate the lack of the badge in the case of (2).
Comment 1 James Henstridge 2017-07-11 03:41:48 UTC
Created attachment 355309 [details] [review]
0001-snap-Install-classic-snaps.patch
Comment 2 James Henstridge 2017-07-11 03:42:10 UTC
Created attachment 355310 [details] [review]
0002-Display-a-warning-for-non-sandboxed-snap-packages.patch

Note You need to log in before you can comment on or make changes to this bug.