GNOME Bugzilla – Bug 784761
keyboard: Consider multiple bindings for default value
Last modified: 2021-06-09 16:27:10 UTC
As mentioned in https://bugzilla.gnome.org/show_bug.cgi?id=673078#c31 and #c32, it may make sense to consider multiple bindings for determining whether a value is at its default. Pros: - it *is* more correct - it simplifies the code (unless we want to allow permutations) Contras: - if the user is unaware that non-primary bindings are a thing, it's confusing if setting an item to the default shortcut (as shown in the UI) isn't always the same as resetting it I'll leave this here for discussion, if we decide that we want this, I'll write a proper commit message :-)
Created attachment 355288 [details] [review] keyboard: Consider multiple bindings for default value
Review of attachment 355288 [details] [review]: The patch looks good to me, and actually removed more lines of code than added =) But we need to have some more feedback here about the feature itself.
CCing Allan. Could you please share your thoughts here?
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.